Regression test for issue where Opus DTX status was being forgotten.

webrtc/voice_engine/voe_codec_unittest.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 133 matching lines @@
   codec2.channels = 2;
   EXPECT_FALSE(codec1 == codec2);
 
   // Reset to codec2 to codec1 state.
   memcpy(&codec2, &codec1, sizeof(CodecInst));
   // Test modifying the |rate|.
   codec2.rate = 0;
   EXPECT_FALSE(codec1 == codec2);
 }
 
+// This is a regression test for
+// https://bugs.chromium.org/p/webrtc/issues/detail?id=6020
+// The Opus DTX setting was being forgotten after unrelated VoE calls.

[minyue-webrtc, 2016/07/25 16:13:01]

do you know what the fixture "VoECodecTest" does?

Can we reuse it? or should be maybe remove it.

[ivoc, 2016/07/25 17:11:10]

I tried reusing it, but it causes a crash (it's calling a virtual function
somewhere). Since it doesn't seem to be used, I guess I can remove it.

[minyue-webrtc, 2016/07/26 09:37:01]

sure, we can remove it in a following CL. Or you can change it and use it as a
base for this new TEST in this CL

[ivoc, 2016/07/26 12:28:31]

I think removing is better in this case, since I don't think that the
setup/teardown code in this test is complicated enough to need a class, and I
don't expect that we'll add a lot of new tests here in the future. I removed the
class in this CL, is that okay with you?

+TEST(VoECodecInst, RememberOpusDtxAfterSettingChange) {
+  VoiceEngine* voe(VoiceEngine::Create());
+  VoEBase* base(VoEBase::GetInterface(voe));
+  VoECodec* voe_codec(VoECodec::GetInterface(voe));
+  std::unique_ptr<FakeAudioDeviceModule> adm(new FakeAudioDeviceModule);
+
+  base->Init(adm.get());
+
+  CodecInst codec = {111, "opus", 48000, 960, 1, 32000};
+
+  int channel = base->CreateChannel();
+
+  bool DTX = false;
+
+  EXPECT_EQ(0, voe_codec->SetSendCodec(channel, codec));
+  EXPECT_EQ(0, voe_codec->SetOpusDtx(channel, true));
+  EXPECT_EQ(0, voe_codec->SetFECStatus(channel, true));
+  EXPECT_EQ(0, voe_codec->GetOpusDtx(channel, &DTX));
+  EXPECT_TRUE(DTX);
+
+  base->DeleteChannel(channel);
+  base->Terminate();
+  base->Release();
+  voe_codec->Release();
+  VoiceEngine::Delete(voe);
+}
+
 }  // namespace
 }  // namespace voe
 }  // namespace webrtc