Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1293)

Side by Side Diff: webrtc/modules/audio_coding/include/audio_coding_module.h

Issue 2177263002: Regression test for issue where Opus DTX status was being forgotten. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Initial version. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 748 matching lines...) Expand 10 before | Expand all | Expand 10 after
759 // int DisableOpusDtx() 759 // int DisableOpusDtx()
760 // If current send codec is Opus, disables its internal DTX. 760 // If current send codec is Opus, disables its internal DTX.
761 // 761 //
762 // Return value: 762 // Return value:
763 // -1 if current send codec is not Opus or error occurred in disabling DTX. 763 // -1 if current send codec is not Opus or error occurred in disabling DTX.
764 // 0 if Opus DTX is disabled successfully. 764 // 0 if Opus DTX is disabled successfully.
765 // 765 //
766 virtual int DisableOpusDtx() = 0; 766 virtual int DisableOpusDtx() = 0;
767 767
768 /////////////////////////////////////////////////////////////////////////// 768 ///////////////////////////////////////////////////////////////////////////
769 // int GetOpusDtx()
minyue-webrtc 2016/07/25 16:13:01 I think we can avoid introducing this function by
ivoc 2016/07/25 17:11:09 Good point, that is indeed a better approach. I ad
770 // If current send codec is Opus, get the status of its internal DTX.
771 //
772 // Return value:
773 // -1 if current send codec is not Opus.
774 // 0 if the Opus DTX status is written to |enabled| successfully.
775 //
776 virtual int GetOpusDtx(bool* enabled) = 0;
777
778 ///////////////////////////////////////////////////////////////////////////
769 // statistics 779 // statistics
770 // 780 //
771 781
772 /////////////////////////////////////////////////////////////////////////// 782 ///////////////////////////////////////////////////////////////////////////
773 // int32_t GetNetworkStatistics() 783 // int32_t GetNetworkStatistics()
774 // Get network statistics. Note that the internal statistics of NetEq are 784 // Get network statistics. Note that the internal statistics of NetEq are
775 // reset by this call. 785 // reset by this call.
776 // 786 //
777 // Input: 787 // Input:
778 // -network_statistics : a structure that contains network statistics. 788 // -network_statistics : a structure that contains network statistics.
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
812 virtual std::vector<uint16_t> GetNackList( 822 virtual std::vector<uint16_t> GetNackList(
813 int64_t round_trip_time_ms) const = 0; 823 int64_t round_trip_time_ms) const = 0;
814 824
815 virtual void GetDecodingCallStatistics( 825 virtual void GetDecodingCallStatistics(
816 AudioDecodingCallStats* call_stats) const = 0; 826 AudioDecodingCallStats* call_stats) const = 0;
817 }; 827 };
818 828
819 } // namespace webrtc 829 } // namespace webrtc
820 830
821 #endif // WEBRTC_MODULES_AUDIO_CODING_INCLUDE_AUDIO_CODING_MODULE_H_ 831 #endif // WEBRTC_MODULES_AUDIO_CODING_INCLUDE_AUDIO_CODING_MODULE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698