webrtc/p2p/base/p2ptransportchannel.h - Issue 2176743003: Merge SignalPortPruned with SignalPortsRemoved in PortAllocatorSession

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/p2p/base/p2ptransportchannel.h

Issue 2176743003: Merge SignalPortPruned with SignalPortsRemoved in PortAllocatorSession (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/p2p/base/p2ptransportchannel.h

diff --git a/webrtc/p2p/base/p2ptransportchannel.h b/webrtc/p2p/base/p2ptransportchannel.h

index 692b09843bf7dbf470cc41a3972bd7a8f8fe03cf..96a6f4ab9d95c09df4de799715eb7de40c1c9bf4 100644

--- a/webrtc/p2p/base/p2ptransportchannel.h

+++ b/webrtc/p2p/base/p2ptransportchannel.h

@@ -276,11 +276,8 @@ class P2PTransportChannel : public TransportChannelImpl,

void AddConnection(Connection* connection);

void OnPortReady(PortAllocatorSession *session, PortInterface* port);

- // TODO(honghaiz): Merge the two methods OnPortsRemoved and OnPortPruned but

- // still log the reason of removing.

void OnPortsRemoved(PortAllocatorSession* session,

const std::vector<PortInterface*>& ports);

pthatcher1 2016/07/27 18:38:11 I like the merging. Can we call it OnPortsPruned?

honghaiz3 2016/07/27 21:31:26 Done.

- void OnPortPruned(PortAllocatorSession* session, PortInterface* port);

void OnCandidatesReady(PortAllocatorSession *session,

const std::vector<Candidate>& candidates);

void OnCandidatesRemoved(PortAllocatorSession* session,

« no previous file with comments | « no previous file | webrtc/p2p/base/p2ptransportchannel.cc » ('j') | webrtc/p2p/base/p2ptransportchannel.cc » ('J')