Merge SignalPortPruned with SignalPortsRemoved in PortAllocatorSession

Merge SignalPortPruned and SignalPortsRemoved.
These two signals have the same purpose and is kind of redundant.
Rename to SignalPortsPruned.

BUG=
R=pthatcher@webrtc.org, zhihuang@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/8eeecabd3345c0f5bd86d7a32d0b57268179bebf

[honghaiz3, 2016-07-22 19:16:31]

Description was changed from

==========
Merge SignalPortPruned to SignalPortsRemoved.

These two signals really have the same purpose.

BUG=
==========

to

==========
Merge SignalPortPruned to SignalPortsRemoved.

These two signals have the same purpose and is kind of redundant. 

BUG=
==========

[honghaiz3, 2016-07-22 19:17:01]

honghaiz@webrtc.org changed reviewers:
+ pthatcher@webrtc.org, zhihuang@webrtc.org

[Zhi Huang, 2016-07-26 04:41:08]

On 2016/07/22 19:17:01, honghaiz3 wrote:

lgtm, with a nit.

[Zhi Huang, 2016-07-26 04:42:17]

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/base/portallocator.h
File webrtc/p2p/base/portallocator.h (right):

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/base/portallocator...
webrtc/p2p/base/portallocator.h:197: // higher-priority TURN port becomes
ready(pairable).
Considering your the other pending CL, the port removal related one
(https://codereview.webrtc.org/2171183002/), I think the comment "or because
these is no connection on the interface" should be modified to be more accurate.
Please correct me if I am wrong.

[pthatcher1, 2016-07-27 18:38:12]

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/base/p2ptransportc...
File webrtc/p2p/base/p2ptransportchannel.cc (right):

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/base/p2ptransportc...
webrtc/p2p/base/p2ptransportchannel.cc:1731: bool
P2PTransportChannel::RemovePort(PortInterface* port) {
This should probably be called OnPortPruned

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/base/p2ptransportc...
File webrtc/p2p/base/p2ptransportchannel.h (left):

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/base/p2ptransportc...
webrtc/p2p/base/p2ptransportchannel.h:282: const std::vector<PortInterface*>&
ports);
I like the merging.  Can we call it OnPortsPruned?

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/base/p2ptransportc...
File webrtc/p2p/base/p2ptransportchannel.h (right):

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/base/p2ptransportc...
webrtc/p2p/base/p2ptransportchannel.h:370: std::vector<PortInterface*>
removed_ports_;
Can we rename removed_ports_ to pruned_ports_?

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/client/basicportal...
File webrtc/p2p/client/basicportallocator.cc (right):

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/client/basicportal...
webrtc/p2p/client/basicportallocator.cc:757: std::vector<PortInterface*>
ports_pruned;
I'd rename these to:

pruned_port => ports_pruned
ports_pruned => pruned_ports

[honghaiz3, 2016-07-27 21:27:37]

Description was changed from

==========
Merge SignalPortPruned to SignalPortsRemoved.

These two signals have the same purpose and is kind of redundant. 

BUG=
==========

to

==========
Merge SignalPortPruned and SignalPortsRemoved.
These two signals have the same purpose and is kind of redundant. 
Rename to SignalPortsPruned.

BUG=
==========

[honghaiz3, 2016-07-27 21:31:27]

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/base/p2ptransportc...
File webrtc/p2p/base/p2ptransportchannel.cc (right):

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/base/p2ptransportc...
webrtc/p2p/base/p2ptransportchannel.cc:1731: bool
P2PTransportChannel::RemovePort(PortInterface* port) {
On 2016/07/27 18:38:11, pthatcher1 wrote:
> This should probably be called OnPortPruned

Done.

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/base/p2ptransportc...
File webrtc/p2p/base/p2ptransportchannel.h (left):

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/base/p2ptransportc...
webrtc/p2p/base/p2ptransportchannel.h:282: const std::vector<PortInterface*>&
ports);
On 2016/07/27 18:38:11, pthatcher1 wrote:
> I like the merging.  Can we call it OnPortsPruned?

Done.

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/base/p2ptransportc...
File webrtc/p2p/base/p2ptransportchannel.h (right):

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/base/p2ptransportc...
webrtc/p2p/base/p2ptransportchannel.h:370: std::vector<PortInterface*>
removed_ports_;
On 2016/07/27 18:38:11, pthatcher1 wrote:
> Can we rename removed_ports_ to pruned_ports_?

Done.

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/base/portallocator.h
File webrtc/p2p/base/portallocator.h (right):

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/base/portallocator...
webrtc/p2p/base/portallocator.h:197: // higher-priority TURN port becomes
ready(pairable).
On 2016/07/26 04:42:17, Zhi Huang wrote:
> Considering your the other pending CL, the port removal related one
> (https://codereview.webrtc.org/2171183002/), I think the comment "or because
> these is no connection on the interface" should be modified to be more
accurate.
> Please correct me if I am wrong.
Probably the name is confusing. Here removal does not mean destroying the port.
It only means removing from usage. When there is no connection on the interface,
we will regathering and before the regathering, we SignalPortsPruned on the
ports using the failed interface.

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/client/basicportal...
File webrtc/p2p/client/basicportallocator.cc (right):

https://codereview.webrtc.org/2176743003/diff/1/webrtc/p2p/client/basicportal...
webrtc/p2p/client/basicportallocator.cc:757: std::vector<PortInterface*>
ports_pruned;
On 2016/07/27 18:38:12, pthatcher1 wrote:
> I'd rename these to:
> 
> pruned_port => ports_pruned
> ports_pruned => pruned_ports
They appears confusing. Change pruned_port to pruned.

https://codereview.webrtc.org/2176743003/diff/20001/webrtc/p2p/client/basicpo...
File webrtc/p2p/client/basicportallocator.cc (left):

https://codereview.webrtc.org/2176743003/diff/20001/webrtc/p2p/client/basicpo...
webrtc/p2p/client/basicportallocator.cc:952: SignalCandidatesRemoved(this,
candidates_to_remove);
It is a little strange to call PortsPruned but CandidatesRemoved. 
However for candidates, I still think "Removed" is probably a better name. 
So I keep its name.

[pthatcher1, 2016-07-28 19:19:15]

lgtm

https://codereview.webrtc.org/2176743003/diff/20001/webrtc/p2p/client/basicpo...
File webrtc/p2p/client/basicportallocator_unittest.cc (right):

https://codereview.webrtc.org/2176743003/diff/20001/webrtc/p2p/client/basicpo...
webrtc/p2p/client/basicportallocator_unittest.cc:420: LOG(LS_INFO) << "Number of
ports removed: " << ports_removed.size();
removed => pruned

[pthatcher1, 2016-07-28 19:19:16]

lgtm

lgtm

https://codereview.webrtc.org/2176743003/diff/20001/webrtc/p2p/client/basicpo...
File webrtc/p2p/client/basicportallocator_unittest.cc (right):

https://codereview.webrtc.org/2176743003/diff/20001/webrtc/p2p/client/basicpo...
webrtc/p2p/client/basicportallocator_unittest.cc:420: LOG(LS_INFO) << "Number of
ports removed: " << ports_removed.size();
removed => pruned

[honghaiz3, 2016-07-28 19:29:52]

Addressed comments.

[honghaiz3, 2016-07-28 19:29:56]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2016-07-28 19:29:57]

The patchset sent to the CQ was uploaded after l-g-t-m from zhihuang@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2176743003/#ps40001 (title:
".")

[commit-bot: I haz the power, 2016-07-28 19:30:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[honghaiz3, 2016-07-28 20:20:33]

Description was changed from

==========
Merge SignalPortPruned and SignalPortsRemoved.
These two signals have the same purpose and is kind of redundant. 
Rename to SignalPortsPruned.

BUG=
==========

to

==========
Merge SignalPortPruned and SignalPortsRemoved.
These two signals have the same purpose and is kind of redundant.
Rename to SignalPortsPruned.

BUG=
R=pthatcher@webrtc.org, zhihuang@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/8eeecabd3345c0f5bd86d7a32...
==========

[commit-bot: I haz the power, 2016-07-28 20:20:34]

Description was changed from

==========
Merge SignalPortPruned and SignalPortsRemoved.
These two signals have the same purpose and is kind of redundant.
Rename to SignalPortsPruned.

BUG=
R=pthatcher@webrtc.org, zhihuang@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/8eeecabd3345c0f5bd86d7a32...
==========

to

==========
Merge SignalPortPruned and SignalPortsRemoved.
These two signals have the same purpose and is kind of redundant.
Rename to SignalPortsPruned.

BUG=
R=pthatcher@webrtc.org, zhihuang@webrtc.org

Committed: https://crrev.com/8eeecabd3345c0f5bd86d7a32d0b57268179bebf
Cr-Commit-Position: refs/heads/master@{#13562}
==========

[honghaiz3, 2016-07-28 20:20:34]

Committed patchset #3 (id:40001) manually as
8eeecabd3345c0f5bd86d7a32d0b57268179bebf (presubmit successful).