Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoFrame.h

Issue 2176623002: iOS render: Handle frame rotation in OpenGL (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@nv21_texture_render
Patch Set: Use webrtc::VideoRotation instead of int Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoFrame.h
diff --git a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoFrame.h b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoFrame.h
index efb666e4bf24824561a34d6e3d86499f680b4fa4..041d970bf86ffda27a5406cf5306a80f044d9252 100644
--- a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoFrame.h
+++ b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoFrame.h
@@ -13,6 +13,8 @@
#import <WebRTC/RTCMacros.h>
+#include "webrtc/common_video/rotation.h"
tkchin_webrtc 2016/08/09 17:42:20 C++ includes cannot be present in pure ObjC header
magjed_webrtc 2016/08/10 10:26:06 Done. I removed the C++ include from this file and
+
NS_ASSUME_NONNULL_BEGIN
// RTCVideoFrame is an ObjectiveC version of cricket::VideoFrame.
@@ -24,6 +26,7 @@ RTC_EXPORT
/** Height without rotation applied. */
@property(nonatomic, readonly) size_t height;
+@property(nonatomic, readonly) webrtc::VideoRotation rotation;
@property(nonatomic, readonly) size_t chromaWidth;
@property(nonatomic, readonly) size_t chromaHeight;
// These can return NULL if the object is not backed by a buffer.
@@ -35,7 +38,7 @@ RTC_EXPORT
@property(nonatomic, readonly) int32_t vPitch;
/** Timestamp in nanoseconds. */
-@property(nonatomic, readonly) int64_t timeStamp;
+@property(nonatomic, readonly) int64_t timeStampNs;
/** The native handle should be a pixel buffer on iOS. */
@property(nonatomic, readonly) CVPixelBufferRef nativeHandle;

Powered by Google App Engine
This is Rietveld 408576698