Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: webrtc/sdk/objc/Framework/Classes/RTCNativeNV12Shader.mm

Issue 2176623002: iOS render: Handle frame rotation in OpenGL (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@nv21_texture_render
Patch Set: Remove unused vertex buffer argument to RTCSetVertexData Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Classes/RTCNativeNV12Shader.mm
diff --git a/webrtc/sdk/objc/Framework/Classes/RTCNativeNV12Shader.mm b/webrtc/sdk/objc/Framework/Classes/RTCNativeNV12Shader.mm
index cc979434e9fcee83e87430f3248811a54d755255..de3927bef256a9ce756e3decfdda5ddf9abce74c 100644
--- a/webrtc/sdk/objc/Framework/Classes/RTCNativeNV12Shader.mm
+++ b/webrtc/sdk/objc/Framework/Classes/RTCNativeNV12Shader.mm
@@ -20,6 +20,7 @@
#import "WebRTC/RTCVideoFrame.h"
#include "webrtc/base/checks.h"
+#include "webrtc/base/optional.h"
static const char kNV12FragmentShaderSource[] =
SHADER_VERSION
@@ -46,6 +47,9 @@ static const char kNV12FragmentShaderSource[] =
GLint _ySampler;
GLint _uvSampler;
CVOpenGLESTextureCacheRef _textureCache;
+ // Store current rotation and only upload new vertex data when rotation
+ // changes.
+ rtc::Optional<int> _current_rotation;
tkchin_webrtc 2016/08/08 22:58:45 ditto
magjed_webrtc 2016/08/09 13:54:27 Done.
}
- (instancetype)initWithContext:(GlContextType *)context {
@@ -149,6 +153,10 @@ static const char kNV12FragmentShaderSource[] =
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
glBindBuffer(GL_ARRAY_BUFFER, _vertexBuffer);
+ if (!_current_rotation || frame.rotation != *_current_rotation) {
+ _current_rotation = rtc::Optional<int>(frame.rotation);
+ RTCSetVertexData(frame.rotation);
+ }
glDrawArrays(GL_TRIANGLE_FAN, 0, 4);
CFRelease(chromaTexture);

Powered by Google App Engine
This is Rietveld 408576698