Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2174343002: Fix a bug where Camera2 tried to start on FPS ranges multiplied by 1000. (Closed)

Created:
4 years, 5 months ago by sakal
Modified:
4 years, 4 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix a bug where Camera2 tried to start on FPS ranges multiplied by 1000. This bug caused Camera2Capturer to not work on Samsung Galaxy S7. BUG=b/30349906 R=magjed@webrtc.org Committed: https://crrev.com/63d3f8390eea5ff8ddabd9e7e64515279cad795d Cr-Commit-Position: refs/heads/master@{#13529}

Patch Set 1 #

Patch Set 2 : Style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -23 lines) Patch
M webrtc/api/android/java/src/org/webrtc/Camera2Capturer.java View 1 1 chunk +4 lines, -6 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/Camera2Enumerator.java View 1 3 chunks +9 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sakal
Magnus, PTAL.
4 years, 5 months ago (2016-07-25 14:55:43 UTC) #1
magjed_webrtc
lgtm
4 years, 4 months ago (2016-07-26 12:42:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2174343002/40001
4 years, 4 months ago (2016-07-26 12:42:21 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-07-26 12:43:36 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 12:43:48 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63d3f8390eea5ff8ddabd9e7e64515279cad795d
Cr-Commit-Position: refs/heads/master@{#13529}

Powered by Google App Engine
This is Rietveld 408576698