Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2171023003: Convert Android camera tests to use the new createVideoSource API. (Closed)

Created:
4 years, 5 months ago by sakal
Modified:
4 years, 4 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Convert Android camera tests to use the new createVideoSource API. Committed: https://crrev.com/2fa14623ccd0410bea89563e7c4fb3dd4488daf9 Cr-Commit-Position: refs/heads/master@{#13528}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Style. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -12 lines) Patch
M webrtc/api/android/java/src/org/webrtc/Camera2Capturer.java View 3 chunks +6 lines, -1 line 0 comments Download
M webrtc/api/androidtests/src/org/webrtc/CameraVideoCapturerTestFixtures.java View 1 9 chunks +20 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
sakal
Magnus, PTAL.
4 years, 5 months ago (2016-07-22 14:45:41 UTC) #2
magjed_webrtc
lgtm https://codereview.webrtc.org/2171023003/diff/1/webrtc/api/androidtests/src/org/webrtc/CameraVideoCapturerTestFixtures.java File webrtc/api/androidtests/src/org/webrtc/CameraVideoCapturerTestFixtures.java (right): https://codereview.webrtc.org/2171023003/diff/1/webrtc/api/androidtests/src/org/webrtc/CameraVideoCapturerTestFixtures.java#newcode365 webrtc/api/androidtests/src/org/webrtc/CameraVideoCapturerTestFixtures.java:365: peerConnectionFactory.createVideoSource(capturer); This fits on the line above now.
4 years, 5 months ago (2016-07-26 09:15:13 UTC) #7
sakal
https://codereview.webrtc.org/2171023003/diff/1/webrtc/api/androidtests/src/org/webrtc/CameraVideoCapturerTestFixtures.java File webrtc/api/androidtests/src/org/webrtc/CameraVideoCapturerTestFixtures.java (right): https://codereview.webrtc.org/2171023003/diff/1/webrtc/api/androidtests/src/org/webrtc/CameraVideoCapturerTestFixtures.java#newcode365 webrtc/api/androidtests/src/org/webrtc/CameraVideoCapturerTestFixtures.java:365: peerConnectionFactory.createVideoSource(capturer); On 2016/07/26 09:15:13, magjed_webrtc wrote: > This fits ...
4 years, 4 months ago (2016-07-26 11:50:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2171023003/20001
4 years, 4 months ago (2016-07-26 11:51:00 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 12:41:42 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 12:41:51 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2fa14623ccd0410bea89563e7c4fb3dd4488daf9
Cr-Commit-Position: refs/heads/master@{#13528}

Powered by Google App Engine
This is Rietveld 408576698