Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: webrtc/base/event_tracer.cc

Issue 2168283002: Fix a crash in the event tracing shutdown path (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/event_tracer.cc
diff --git a/webrtc/base/event_tracer.cc b/webrtc/base/event_tracer.cc
index 57c28fcbdc37ff92a0b891ff0af9d0cf460e37a5..8802095680092581982c51c43553fbfe6d1b220c 100644
--- a/webrtc/base/event_tracer.cc
+++ b/webrtc/base/event_tracer.cc
@@ -197,7 +197,9 @@ class EventLogger final {
static bool EventTracingThreadFunc(void* params) {
static_cast<EventLogger*>(params)->Log();
- return true;
+ // False indicates that the thread function has done its job and doesn't need
+ // to be restarted again. Log() runs its own internal loop.
+ return false;
}
static EventLogger* volatile g_event_logger = nullptr;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698