Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: webrtc/base/sslstreamadapter.h

Issue 2167363002: Log how often DTLS negotiation failed because of incompatible ciphersuites. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Remove the new defined enum. Use the error code in ssl.h directly. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/sslstreamadapter.h
diff --git a/webrtc/base/sslstreamadapter.h b/webrtc/base/sslstreamadapter.h
index ba60ce3da09b32ce28b832597784cdaa78e0866a..f1a0a32994c7a08619292a8d2bdd975bea0d8285 100644
--- a/webrtc/base/sslstreamadapter.h
+++ b/webrtc/base/sslstreamadapter.h
@@ -83,9 +83,8 @@ class SSLStreamAdapter : public StreamAdapterInterface {
// Caller is responsible for freeing the returned object.
static SSLStreamAdapter* Create(StreamInterface* stream);
- explicit SSLStreamAdapter(StreamInterface* stream)
- : StreamAdapterInterface(stream), ignore_bad_cert_(false),
- client_auth_enabled_(true) { }
+ explicit SSLStreamAdapter(StreamInterface* stream);
+ ~SSLStreamAdapter() override;
void set_ignore_bad_cert(bool ignore) { ignore_bad_cert_ = ignore; }
bool ignore_bad_cert() const { return ignore_bad_cert_; }
@@ -207,6 +206,8 @@ class SSLStreamAdapter : public StreamAdapterInterface {
// depending on specific SSL implementation.
static std::string SslCipherSuiteToName(int cipher_suite);
+ sigslot::signal1<int> SignalSSLHandshakeError;
pthatcher1 2016/08/03 22:40:46 We should document what values will be in here. I
+
private:
// If true, the server certificate need not match the configured
// server_name, and in fact missing certificate authority and other

Powered by Google App Engine
This is Rietveld 408576698