Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1671)

Unified Diff: webrtc/api/webrtcsession.cc

Issue 2167363002: Log how often DTLS negotiation failed because of incompatible ciphersuites. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Remove the new defined enum. Use the error code in ssl.h directly. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/webrtcsession.cc
diff --git a/webrtc/api/webrtcsession.cc b/webrtc/api/webrtcsession.cc
index 8c83dbbc62a414cd304c44409c9630d4e08887f4..dabd27393daa5d543b4097469dc507f4047acb26 100644
--- a/webrtc/api/webrtcsession.cc
+++ b/webrtc/api/webrtcsession.cc
@@ -487,6 +487,8 @@ WebRtcSession::WebRtcSession(webrtc::MediaControllerInterface* media_controller,
this, &WebRtcSession::OnTransportControllerCandidatesGathered);
transport_controller_->SignalCandidatesRemoved.connect(
this, &WebRtcSession::OnTransportControllerCandidatesRemoved);
+ transport_controller_->SignalDtlsHandshakeError.connect(
+ this, &WebRtcSession::OnDtlsHandshakeError);
}
WebRtcSession::~WebRtcSession() {
@@ -2008,4 +2010,11 @@ void WebRtcSession::OnSentPacket_w(const rtc::SentPacket& sent_packet) {
media_controller_->call_w()->OnSentPacket(sent_packet);
}
+void WebRtcSession::OnDtlsHandshakeError(int error) {
+ if (metrics_observer_) {
+ metrics_observer_->IncrementSparseEnumCounter(
+ webrtc::kEnumCounterDtlsHandshakeError, error);
+ }
+}
+
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698