webrtc/base/opensslstreamadapter.cc - Issue 2167363002: Log how often DTLS negotiation failed because of incompatible ciphersuites.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/opensslstreamadapter.cc

Issue 2167363002: Log how often DTLS negotiation failed because of incompatible ciphersuites. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/base/opensslstreamadapter.cc

diff --git a/webrtc/base/opensslstreamadapter.cc b/webrtc/base/opensslstreamadapter.cc

index e04eb04d67c8d05eee38938f406484ccbe5d5247..ac84dec0b6ad5fc7b897cea29c21c53ac53a4dfd 100644

--- a/webrtc/base/opensslstreamadapter.cc

+++ b/webrtc/base/opensslstreamadapter.cc

@@ -854,6 +854,13 @@ int OpenSSLStreamAdapter::ContinueSSL() {

case SSL_ERROR_ZERO_RETURN:

default:

LOG(LS_VERBOSE) << " -- error " << code;

+ SSLHandshakeError ssl_handshake_err = SSLHandshakeError::ERR_OTHER;

+ int err_code = 0;

+ if ((err_code = ERR_peek_last_error()) != 0 &&

honghaiz3 2016/07/22 21:35:26 you could do int err_code = ERR_peek_last_error();

Zhi Huang 2016/07/25 17:24:28 Done.

+ ERR_GET_REASON(err_code) == SSL_R_NO_SHARED_CIPHER) {

+ ssl_handshake_err = SSLHandshakeError::ERR_INCOMPATIBLE_CIPHERSUITE;

+ }

+ SignalSSLHandshakeError(ssl_handshake_err);

return (ssl_error != 0) ? ssl_error : -1;

}

« webrtc/api/webrtcsession.cc ('K') | « webrtc/api/webrtcsession.cc ('k') | webrtc/base/sslstreamadapter.h » ('j') | webrtc/base/sslstreamadapter.h » ('J')