Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: webrtc/p2p/base/dtlstransportchannel.cc

Issue 2167363002: Log how often DTLS negotiation failed because of incompatible ciphersuites. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Use enum for handshake error code. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/p2p/base/dtlstransportchannel.h ('k') | webrtc/p2p/base/transportchannelimpl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2011 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2011 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 return false; 273 return false;
274 } 274 }
275 275
276 downward_ = downward; 276 downward_ = downward;
277 277
278 dtls_->SetIdentity(local_certificate_->identity()->GetReference()); 278 dtls_->SetIdentity(local_certificate_->identity()->GetReference());
279 dtls_->SetMode(rtc::SSL_MODE_DTLS); 279 dtls_->SetMode(rtc::SSL_MODE_DTLS);
280 dtls_->SetMaxProtocolVersion(ssl_max_version_); 280 dtls_->SetMaxProtocolVersion(ssl_max_version_);
281 dtls_->SetServerRole(ssl_role_); 281 dtls_->SetServerRole(ssl_role_);
282 dtls_->SignalEvent.connect(this, &DtlsTransportChannelWrapper::OnDtlsEvent); 282 dtls_->SignalEvent.connect(this, &DtlsTransportChannelWrapper::OnDtlsEvent);
283 dtls_->SignalSSLHandshakeError.connect(
284 this, &DtlsTransportChannelWrapper::OnDtlsHandshakeError);
283 if (!dtls_->SetPeerCertificateDigest( 285 if (!dtls_->SetPeerCertificateDigest(
284 remote_fingerprint_algorithm_, 286 remote_fingerprint_algorithm_,
285 reinterpret_cast<unsigned char*>(remote_fingerprint_value_.data()), 287 reinterpret_cast<unsigned char*>(remote_fingerprint_value_.data()),
286 remote_fingerprint_value_.size())) { 288 remote_fingerprint_value_.size())) {
287 LOG_J(LS_ERROR, this) << "Couldn't set DTLS certificate digest."; 289 LOG_J(LS_ERROR, this) << "Couldn't set DTLS certificate digest.";
288 return false; 290 return false;
289 } 291 }
290 292
291 // Set up DTLS-SRTP, if it's been enabled. 293 // Set up DTLS-SRTP, if it's been enabled.
292 if (!srtp_ciphers_.empty()) { 294 if (!srtp_ciphers_.empty()) {
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
669 SignalSelectedCandidatePairChanged(this, selected_candidate_pair, 671 SignalSelectedCandidatePairChanged(this, selected_candidate_pair,
670 last_sent_packet_id, ready_to_send); 672 last_sent_packet_id, ready_to_send);
671 } 673 }
672 674
673 void DtlsTransportChannelWrapper::OnChannelStateChanged( 675 void DtlsTransportChannelWrapper::OnChannelStateChanged(
674 TransportChannelImpl* channel) { 676 TransportChannelImpl* channel) {
675 ASSERT(channel == channel_); 677 ASSERT(channel == channel_);
676 SignalStateChanged(this); 678 SignalStateChanged(this);
677 } 679 }
678 680
681 void DtlsTransportChannelWrapper::OnDtlsHandshakeError(
682 rtc::SSLHandshakeError error) {
683 SignalDtlsHandshakeError(error);
684 }
685
679 } // namespace cricket 686 } // namespace cricket
OLDNEW
« no previous file with comments | « webrtc/p2p/base/dtlstransportchannel.h ('k') | webrtc/p2p/base/transportchannelimpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698