Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: webrtc/api/webrtcsession.cc

Issue 2167363002: Log how often DTLS negotiation failed because of incompatible ciphersuites. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Use enum for handshake error code. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/webrtcsession.h ('k') | webrtc/base/opensslstreamadapter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 475 matching lines...) Expand 10 before | Expand all | Expand 10 after
486 transport_controller_->SignalConnectionState.connect( 486 transport_controller_->SignalConnectionState.connect(
487 this, &WebRtcSession::OnTransportControllerConnectionState); 487 this, &WebRtcSession::OnTransportControllerConnectionState);
488 transport_controller_->SignalReceiving.connect( 488 transport_controller_->SignalReceiving.connect(
489 this, &WebRtcSession::OnTransportControllerReceiving); 489 this, &WebRtcSession::OnTransportControllerReceiving);
490 transport_controller_->SignalGatheringState.connect( 490 transport_controller_->SignalGatheringState.connect(
491 this, &WebRtcSession::OnTransportControllerGatheringState); 491 this, &WebRtcSession::OnTransportControllerGatheringState);
492 transport_controller_->SignalCandidatesGathered.connect( 492 transport_controller_->SignalCandidatesGathered.connect(
493 this, &WebRtcSession::OnTransportControllerCandidatesGathered); 493 this, &WebRtcSession::OnTransportControllerCandidatesGathered);
494 transport_controller_->SignalCandidatesRemoved.connect( 494 transport_controller_->SignalCandidatesRemoved.connect(
495 this, &WebRtcSession::OnTransportControllerCandidatesRemoved); 495 this, &WebRtcSession::OnTransportControllerCandidatesRemoved);
496 transport_controller_->SignalDtlsHandshakeError.connect(
497 this, &WebRtcSession::OnDtlsHandshakeError);
496 } 498 }
497 499
498 WebRtcSession::~WebRtcSession() { 500 WebRtcSession::~WebRtcSession() {
499 ASSERT(signaling_thread()->IsCurrent()); 501 ASSERT(signaling_thread()->IsCurrent());
500 // Destroy video_channel_ first since it may have a pointer to the 502 // Destroy video_channel_ first since it may have a pointer to the
501 // voice_channel_. 503 // voice_channel_.
502 if (video_channel_) { 504 if (video_channel_) {
503 SignalVideoChannelDestroyed(); 505 SignalVideoChannelDestroyed();
504 channel_manager_->DestroyVideoChannel(video_channel_.release()); 506 channel_manager_->DestroyVideoChannel(video_channel_.release());
505 } 507 }
(...skipping 1560 matching lines...) Expand 10 before | Expand all | Expand 10 after
2066 if (data_channel_type_ == cricket::DCT_QUIC && quic_data_transport_ && 2068 if (data_channel_type_ == cricket::DCT_QUIC && quic_data_transport_ &&
2067 content_name == quic_data_transport_->transport_name()) { 2069 content_name == quic_data_transport_->transport_name()) {
2068 return quic_data_transport_->transport_name(); 2070 return quic_data_transport_->transport_name();
2069 } 2071 }
2070 #endif 2072 #endif
2071 // Return an empty string if failed to retrieve the transport name. 2073 // Return an empty string if failed to retrieve the transport name.
2072 return ""; 2074 return "";
2073 } 2075 }
2074 return channel->transport_name(); 2076 return channel->transport_name();
2075 } 2077 }
2078
2079 void WebRtcSession::OnDtlsHandshakeError(rtc::SSLHandshakeError error) {
2080 if (metrics_observer_) {
2081 metrics_observer_->IncrementEnumCounter(
2082 webrtc::kEnumCounterDtlsHandshakeError, static_cast<int>(error),
2083 static_cast<int>(rtc::SSLHandshakeError::MAX_VALUE));
2084 }
2085 }
2076 } // namespace webrtc 2086 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/api/webrtcsession.h ('k') | webrtc/base/opensslstreamadapter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698