Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2166493004: Reland of "Protect MessageQueue stop field with a critical section to avoid data races." (refs/head… (Closed)

Created:
4 years, 5 months ago by andresp
Modified:
4 years, 5 months ago
Reviewers:
tommi, mflodman, Taylor
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of "Protect MessageQueue stop field with a critical section to avoid data races." (refs/heads/master@{#13430}). It was reverted in "refs/heads/master@{#13431}" due to breaking Chrome FYI bots. Fix for chromium was submmited in https://codereview.chromium.org/2159753002. This reverts commit a2c900877d8338130210c99fec1c8e8e59defea4. R=mflodman@webrtc.org Committed: https://crrev.com/02a57979086c798c9be837bbc77221ccdee4c16d Cr-Commit-Position: refs/heads/master@{#13508}

Patch Set 1 #

Patch Set 2 : rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M webrtc/base/messagequeue.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/base/messagequeue.cc View 5 chunks +12 lines, -8 lines 0 comments Download
M webrtc/base/thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/build/sanitizers/tsan_suppressions_webrtc.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (11 generated)
andresp
Hi Magnus can you have a look? This cl was already approved once but it ...
4 years, 5 months ago (2016-07-20 10:56:55 UTC) #3
mflodman
LGTM You could also press the revert button in https://codereview.webrtc.org/2135173002/ to get a revert-of-the-revert message ...
4 years, 5 months ago (2016-07-20 12:34:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2166493004/1
4 years, 5 months ago (2016-07-20 14:07:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/9513)
4 years, 5 months ago (2016-07-20 15:11:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2166493004/1
4 years, 5 months ago (2016-07-22 08:13:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_gn_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn_rel/builds/12432)
4 years, 5 months ago (2016-07-22 08:36:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2166493004/20001
4 years, 5 months ago (2016-07-22 11:13:47 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/builds/4018)
4 years, 5 months ago (2016-07-22 11:24:37 UTC) #17
andresp
4 years, 5 months ago (2016-07-22 11:30:24 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
02a57979086c798c9be837bbc77221ccdee4c16d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698