Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: webrtc/media/engine/webrtcvoiceengine.cc

Issue 2165743003: Variable audio bitrate. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/webrtcvoiceengine.cc
diff --git a/webrtc/media/engine/webrtcvoiceengine.cc b/webrtc/media/engine/webrtcvoiceengine.cc
index 469098a32274973cb38189eb8094336920ae113c..dcc9273002394fee2b71f889b91c639a4f5dea44 100644
--- a/webrtc/media/engine/webrtcvoiceengine.cc
+++ b/webrtc/media/engine/webrtcvoiceengine.cc
@@ -1136,6 +1136,13 @@ class WebRtcVoiceMediaChannel::WebRtcAudioSendStream
stream_ = nullptr;
}
config_.rtp.extensions = extensions;
+ if (webrtc::field_trial::FindFullName("WebRTC-AdaptAudioBitrate") ==
+ "Enabled") {
+ // TODO(mflodman):Set this properly.
+ config_.min_bitrate_kbps = kOpusMinBitrate;
+ config_.max_bitrate_kbps = kOpusBitrateFb;
stefan-webrtc 2016/07/20 10:15:00 kOpusBitrateFb seems like a bad variable name. Cou
minyue-webrtc 2016/07/21 10:59:19 is it possible to use kOpusMaxBitrate (although we
mflodman 2016/07/22 13:50:29 @minyue: I didn't want to increase the bitrate mor
mflodman 2016/07/22 13:50:29 @stefan: There are three different Opus bitrate c
stefan-webrtc 2016/07/25 15:06:20 I see. Probably good enough then, although I would
mflodman 2016/07/26 09:50:52 I agree and I'll bring that up for discussion.
+ }
+
RTC_DCHECK(!stream_);
stream_ = call_->CreateAudioSendStream(config_);
RTC_CHECK(stream_);

Powered by Google App Engine
This is Rietveld 408576698