Add loss-based BWE estimate to the outgoing bitrate plot.

webrtc/tools/event_log_visualizer/analyzer.cc

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 186 matching lines @@
       case ParsedRtcEventLog::RTCP_EVENT: {
         break;
       }
       case ParsedRtcEventLog::LOG_START: {
         break;
       }
       case ParsedRtcEventLog::LOG_END: {
         break;
       }
       case ParsedRtcEventLog::BWE_PACKET_LOSS_EVENT: {
+        uint64_t timestamp = parsed_log_.GetTimestamp(i);
+        int32_t bitrate;
+        uint8_t fraction_loss;
+        int32_t expected_packets;
+        parsed_log_.GetBwePacketLossEvent(i, &bitrate, &fraction_loss,
+                                          &expected_packets);
+        bwe_loss_updates_.push_back(BwePacketLossEvent(

[ivoc, 2016/07/19 09:42:48]

You could use emplace_back here to construct the object directly within the
container.

[terelius, 2016/07/19 13:06:18]

Changed the GetBwePacketLossEvent to write the directly to the
BwePacketLossEvent object instead. While it doesn't use emplace_back, I think
this is about as efficient and it is a few lines shorter. Wdyt?

+            timestamp, bitrate, fraction_loss, expected_packets));
         break;
       }
       case ParsedRtcEventLog::BWE_PACKET_DELAY_EVENT: {
         break;
       }
       case ParsedRtcEventLog::AUDIO_PLAYOUT_EVENT: {
         break;
       }
       case ParsedRtcEventLog::UNKNOWN_EVENT: {
         break;
@@ skipping 333 matching lines @@
   }
 
   // Set labels.
   if (desired_direction == webrtc::PacketDirection::kIncomingPacket) {
     plot->series.back().label = "Incoming bitrate";
   } else if (desired_direction == webrtc::PacketDirection::kOutgoingPacket) {
     plot->series.back().label = "Outgoing bitrate";
   }
   plot->series.back().style = LINE_GRAPH;
 
+  // Overlay the send-side bandwidth estimate over the outgoing bitrate.
+  if (desired_direction == kOutgoingPacket) {
+    plot->series.push_back(TimeSeries());
+    for (auto& bwe_update : bwe_loss_updates_) {
+      float x =
+          static_cast<float>(bwe_update.timestamp - begin_time_) / 1000000;
+      float y = static_cast<float>(bwe_update.new_bitrate) / 1000;
+      max_y = std::max(max_y, y);
+      plot->series.back().points.push_back(TimeSeriesPoint(x, y));

[ivoc, 2016/07/19 09:42:48]

Another opportunity for emplace_back.

[terelius, 2016/07/19 13:06:18]

Done.

+    }
+    plot->series.back().label = "Loss-based estimate";
+    plot->series.back().style = LINE_GRAPH;
+  }
+
   plot->xaxis_min = kDefaultXMin;
   plot->xaxis_max = (end_time_ - begin_time_) / 1000000 * kXMargin;
   plot->xaxis_label = "Time (s)";
   plot->yaxis_min = kDefaultYMin;
   plot->yaxis_max = max_y * kYMargin;
   plot->yaxis_label = "Bitrate (kbps)";
   if (desired_direction == webrtc::PacketDirection::kIncomingPacket) {
     plot->title = "Incoming RTP bitrate";
   } else if (desired_direction == webrtc::PacketDirection::kOutgoingPacket) {
     plot->title = "Outgoing RTP bitrate";
@@ skipping 80 matching lines @@
   plot->yaxis_label = "Bitrate (kbps)";
   if (desired_direction == webrtc::PacketDirection::kIncomingPacket) {
     plot->title = "Incoming bitrate per stream";
   } else if (desired_direction == webrtc::PacketDirection::kOutgoingPacket) {
     plot->title = "Outgoing bitrate per stream";
   }
 }
 
 }  // namespace plotting
 }  // namespace webrtc