Prepare for ICE-renomination

webrtc/p2p/base/transport.h

Index: webrtc/p2p/base/transport.h
diff --git a/webrtc/p2p/base/transport.h b/webrtc/p2p/base/transport.h
index a7ca72ff8ea1ed8979d29486ed1f564572d4b281..716665a023bb840197c7b9dce9e7e6535d39541f 100644
--- a/webrtc/p2p/base/transport.h
+++ b/webrtc/p2p/base/transport.h
@@ -162,6 +162,9 @@ struct TransportStats {
   TransportChannelStatsList channel_stats;
 };
 
+// ICE Nomination mode.

[pthatcher1, 2016/08/03 22:13:25]

Can you move the definitions of these from the other comment to this comment?

[honghaiz3, 2016/08/03 23:39:52]

Done. I kept the details of SEMI_AGGRESSIVE in p2ptransportchannel. It is
probably more readable. 

+enum class NominationMode { REGULAR, AGGRESSIVE, SEMI_AGGRESSIVE };
+
 // Information about ICE configuration.
 // TODO(deadbeef): Use rtc::Optional to represent unset values, instead of
 // -1.
@@ -199,6 +202,9 @@ struct IceConfig {
   // in case that the selected connection may become receiving soon.
   rtc::Optional<int> receiving_switching_delay;
 
+  // Default nomination mode if the remote does not support renomination.
+  NominationMode default_nomination_mode = NominationMode::SEMI_AGGRESSIVE;

[pthatcher1, 2016/08/03 22:13:25]

Can you put a TODO to change it to REGULAR? 

[honghaiz3, 2016/08/03 23:39:52]

Done.

+
   IceConfig() {}
   IceConfig(int receiving_timeout_ms,
             int backup_connection_ping_interval,