Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 5 months ago by buildbot Modified:
4 years, 5 months ago Reviewers:
ehmaldonado_webrtc, phoglund, marpan2 CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRoll chromium_revision bfec2ff09d..0259d67099 (404886:406454)
Change log: https://chromium.googlesource.com/chromium/src/+log/bfec2ff09d..0259d67099
Full diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..0259d67099
Changed dependencies:
* src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/aa47d9773d..55638fe5c3
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/95c69563dc..3a28755bad
* src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/1c0a9f36f1..d6197b621d
* src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/76aee8ced7..e74086bfe3
* src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/bac4680ec9..e7079f0e0e
* src/tools/swarming_client: https://chromium.googlesource.com/external/swarming.client.git/+log/df6e95e766..7f63a272f7
DEPS diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..0259d67099/DEPS
No update to Clang.
phoglund: assuming iOS error was a flake (something about a compiler i/o error), landing anyway since everything else looks good.
TBR=marpan@webrtc.org,
NOTRY=true
Committed: https://crrev.com/63dcecd5c15a872b5a488e1dd3e935c5eb91ee41
Cr-Commit-Position: refs/heads/master@{#13501}
Patch Set 1 #Messages
Total messages: 16 (8 generated)
The CQ bit was checked by buildbot@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gn_rel/builds/1244)
Description was changed from ========== Roll chromium_revision bfec2ff09d..0259d67099 (404886:406454) Change log: https://chromium.googlesource.com/chromium/src/+log/bfec2ff09d..0259d67099 Full diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..0259d67099 Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/aa47d9773d..55... * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/95c69563dc..3a28755bad * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/1c0a9f36f1..d6197b621d * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/76aee8ced7..e74086bfe3 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/bac4680ec9..e7079f0e0e * src/tools/swarming_client: https://chromium.googlesource.com/external/swarming.client.git/+log/df6e95e76... DEPS diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..0259d67099/DEPS No update to Clang. TBR=marpan@webrtc.org, ========== to ========== Roll chromium_revision bfec2ff09d..0259d67099 (404886:406454) Change log: https://chromium.googlesource.com/chromium/src/+log/bfec2ff09d..0259d67099 Full diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..0259d67099 Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/aa47d9773d..55... * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/95c69563dc..3a28755bad * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/1c0a9f36f1..d6197b621d * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/76aee8ced7..e74086bfe3 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/bac4680ec9..e7079f0e0e * src/tools/swarming_client: https://chromium.googlesource.com/external/swarming.client.git/+log/df6e95e76... DEPS diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..0259d67099/DEPS No update to Clang. TBR=marpan@webrtc.org, NOTRY=true ==========
Description was changed from ========== Roll chromium_revision bfec2ff09d..0259d67099 (404886:406454) Change log: https://chromium.googlesource.com/chromium/src/+log/bfec2ff09d..0259d67099 Full diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..0259d67099 Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/aa47d9773d..55... * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/95c69563dc..3a28755bad * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/1c0a9f36f1..d6197b621d * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/76aee8ced7..e74086bfe3 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/bac4680ec9..e7079f0e0e * src/tools/swarming_client: https://chromium.googlesource.com/external/swarming.client.git/+log/df6e95e76... DEPS diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..0259d67099/DEPS No update to Clang. TBR=marpan@webrtc.org, NOTRY=true ========== to ========== Roll chromium_revision bfec2ff09d..0259d67099 (404886:406454) Change log: https://chromium.googlesource.com/chromium/src/+log/bfec2ff09d..0259d67099 Full diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..0259d67099 Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/aa47d9773d..55... * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/95c69563dc..3a28755bad * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/1c0a9f36f1..d6197b621d * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/76aee8ced7..e74086bfe3 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/bac4680ec9..e7079f0e0e * src/tools/swarming_client: https://chromium.googlesource.com/external/swarming.client.git/+log/df6e95e76... DEPS diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..0259d67099/DEPS No update to Clang. phoglund: assuming iOS error was a flake (something about a compiler i/o error), landing anyway since everything else looks good. TBR=marpan@webrtc.org, NOTRY=true ==========
phoglund@webrtc.org changed reviewers: + ehmaldonado@webrtc.org, phoglund@webrtc.org
lgtm lgtm
The CQ bit was checked by phoglund@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Roll chromium_revision bfec2ff09d..0259d67099 (404886:406454) Change log: https://chromium.googlesource.com/chromium/src/+log/bfec2ff09d..0259d67099 Full diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..0259d67099 Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/aa47d9773d..55... * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/95c69563dc..3a28755bad * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/1c0a9f36f1..d6197b621d * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/76aee8ced7..e74086bfe3 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/bac4680ec9..e7079f0e0e * src/tools/swarming_client: https://chromium.googlesource.com/external/swarming.client.git/+log/df6e95e76... DEPS diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..0259d67099/DEPS No update to Clang. phoglund: assuming iOS error was a flake (something about a compiler i/o error), landing anyway since everything else looks good. TBR=marpan@webrtc.org, NOTRY=true ========== to ========== Roll chromium_revision bfec2ff09d..0259d67099 (404886:406454) Change log: https://chromium.googlesource.com/chromium/src/+log/bfec2ff09d..0259d67099 Full diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..0259d67099 Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/aa47d9773d..55... * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/95c69563dc..3a28755bad * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/1c0a9f36f1..d6197b621d * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/76aee8ced7..e74086bfe3 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/bac4680ec9..e7079f0e0e * src/tools/swarming_client: https://chromium.googlesource.com/external/swarming.client.git/+log/df6e95e76... DEPS diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..0259d67099/DEPS No update to Clang. phoglund: assuming iOS error was a flake (something about a compiler i/o error), landing anyway since everything else looks good. TBR=marpan@webrtc.org, NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll chromium_revision bfec2ff09d..0259d67099 (404886:406454) Change log: https://chromium.googlesource.com/chromium/src/+log/bfec2ff09d..0259d67099 Full diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..0259d67099 Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/aa47d9773d..55... * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/95c69563dc..3a28755bad * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/1c0a9f36f1..d6197b621d * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/76aee8ced7..e74086bfe3 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/bac4680ec9..e7079f0e0e * src/tools/swarming_client: https://chromium.googlesource.com/external/swarming.client.git/+log/df6e95e76... DEPS diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..0259d67099/DEPS No update to Clang. phoglund: assuming iOS error was a flake (something about a compiler i/o error), landing anyway since everything else looks good. TBR=marpan@webrtc.org, NOTRY=true ========== to ========== Roll chromium_revision bfec2ff09d..0259d67099 (404886:406454) Change log: https://chromium.googlesource.com/chromium/src/+log/bfec2ff09d..0259d67099 Full diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..0259d67099 Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/aa47d9773d..55... * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/95c69563dc..3a28755bad * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/1c0a9f36f1..d6197b621d * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/76aee8ced7..e74086bfe3 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/bac4680ec9..e7079f0e0e * src/tools/swarming_client: https://chromium.googlesource.com/external/swarming.client.git/+log/df6e95e76... DEPS diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..0259d67099/DEPS No update to Clang. phoglund: assuming iOS error was a flake (something about a compiler i/o error), landing anyway since everything else looks good. TBR=marpan@webrtc.org, NOTRY=true Committed: https://crrev.com/63dcecd5c15a872b5a488e1dd3e935c5eb91ee41 Cr-Commit-Position: refs/heads/master@{#13501} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/63dcecd5c15a872b5a488e1dd3e935c5eb91ee41 Cr-Commit-Position: refs/heads/master@{#13501}
Message was sent while issue was closed.
Appears I was wrong, maybe the iOS thing was real after all. Either way, I think we'll have to try to fix that rather than rolling this back, it's been too long without a successful chromium roll. |
