webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h - Issue 2157843002: Fix crash which happens when there's reordering in the beginning of a call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h

Issue 2157843002: Fix crash which happens when there's reordering in the beginning of a call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressed comment. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h

diff --git a/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h b/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h

index 66373e29778937dd5d9ee78b144ff0c0bfb7c5ba..127886300d8f95c2fd14d78ebc0ffae9ee5c1094 100644

--- a/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h

+++ b/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h

@@ -54,7 +54,7 @@ class RemoteEstimatorProxy : public RemoteBitrateEstimator {

private:

void OnPacketArrival(uint16_t sequence_number, int64_t arrival_time)

EXCLUSIVE_LOCKS_REQUIRED(&lock_);

- bool BuildFeedbackPacket(rtcp::TransportFeedback* feedback_packetket);

+ bool BuildFeedbackPacket(rtcp::TransportFeedback* feedback_packet);

Clock* const clock_;

PacketRouter* const packet_router_;

« no previous file with comments | « no previous file | webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc » ('j') | no next file with comments »