Make rtc_include_tests true by default in gn.

Make rtc_include_tests true by default in gn.

See bug for discussion.

BUG=webrtc:6119
TBR=kjellander@webrtc.org

Committed: https://crrev.com/18832f6c35174cb94aa497e600235193f90bc79e
Cr-Commit-Position: refs/heads/master@{#13500}

[phoglund, 2016-07-18 15:16:32]

phoglund@webrtc.org changed reviewers:
+ ehmaldonado@webrtc.org, kjellander@webrtc.org

[phoglund, 2016-07-18 15:16:50]

Description was changed from

==========
Make rtc_include_tests true by default in gn.

See bug for discussion.

BUG=webrtc:6119
==========

to

==========
Make rtc_include_tests true by default in gn.

See bug for discussion.

BUG=webrtc:6119
TBR=kjellander@webrtc.org
==========

[brettw, 2016-07-19 17:42:42]

brettw@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2016-07-19 17:42:44]

lgtm

https://codereview.webrtc.org/2156203002/diff/20001/build_overrides/webrtc.gni
File build_overrides/webrtc.gni (right):

https://codereview.webrtc.org/2156203002/diff/20001/build_overrides/webrtc.gn...
build_overrides/webrtc.gni:26: # Include tests in standalone checkout.
Can you put the comment right above the variable (down one line)? GN will
automatically treat them as docstrings and they'll appear in "gn args --list"
but this will break if there's another line in between the variable and the
comment.

[phoglund, 2016-07-19 19:16:21]

https://codereview.webrtc.org/2156203002/diff/20001/build_overrides/webrtc.gni
File build_overrides/webrtc.gni (right):

https://codereview.webrtc.org/2156203002/diff/20001/build_overrides/webrtc.gn...
build_overrides/webrtc.gni:26: # Include tests in standalone checkout.
On 2016/07/19 17:42:44, brettw (ping after 24h) wrote:
> Can you put the comment right above the variable (down one line)? GN will
> automatically treat them as docstrings and they'll appear in "gn args --list"
> but this will break if there's another line in between the variable and the
> comment.

Done.

[phoglund, 2016-07-19 19:16:28]

The CQ bit was checked by phoglund@webrtc.org

[phoglund, 2016-07-19 19:16:28]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.webrtc.org/2156203002/#ps40001 (title:
"Move comment.")

[commit-bot: I haz the power, 2016-07-19 19:16:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-19 19:56:52]

Description was changed from

==========
Make rtc_include_tests true by default in gn.

See bug for discussion.

BUG=webrtc:6119
TBR=kjellander@webrtc.org
==========

to

==========
Make rtc_include_tests true by default in gn.

See bug for discussion.

BUG=webrtc:6119
TBR=kjellander@webrtc.org
==========

[commit-bot: I haz the power, 2016-07-19 19:56:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-19 19:57:00]

Description was changed from

==========
Make rtc_include_tests true by default in gn.

See bug for discussion.

BUG=webrtc:6119
TBR=kjellander@webrtc.org
==========

to

==========
Make rtc_include_tests true by default in gn.

See bug for discussion.

BUG=webrtc:6119
TBR=kjellander@webrtc.org

Committed: https://crrev.com/18832f6c35174cb94aa497e600235193f90bc79e
Cr-Commit-Position: refs/heads/master@{#13500}
==========

[commit-bot: I haz the power, 2016-07-19 19:57:01]

Patchset 3 (id:??) landed as
https://crrev.com/18832f6c35174cb94aa497e600235193f90bc79e
Cr-Commit-Position: refs/heads/master@{#13500}

[kjellander_webrtc, 2016-07-24 08:33:57]

lgtm