Always take retransmissions into account when deciding pacing order

Always take retransmissions into account when deciding pacing order

Retransmissions are supposed to be sent before normal packets by the pacer, but the current implementation will only use it if the second packet is a retransmission and the first packet is not. It misses the case where the first packet is retransmission and the second packet is not.

This CL fixes the comparator and adds a unit test.

Also changed the SendAndExpectPacket function to propagate the retransmission flag to the expectations. Previously, all packets were expected to be normal packets.

BUG=webrtc:6124
Committed: https://crrev.com/f39f7d931c11045fe0ba842e4eba9b816f0288ca
Cr-Commit-Position: refs/heads/master@{#13502}

[terelius, 2016-07-18 16:20:25]

terelius@webrtc.org changed reviewers:
+ pbos@webrtc.org, stefan@webrtc.org

[terelius, 2016-07-18 16:20:26]

Please take a look

[pbos-webrtc, 2016-07-18 16:22:44]

add a test that catches this please :)

[terelius, 2016-07-19 12:47:33]

Description was changed from

==========
Always take retransmissions into account when deciding pacing order

Retransmissions are supposed to be sent before normal packets by the pacer, but
the current implementation will only use it if the second packet is a
retransmission and the first packet is not. It misses the case where the first
packet is retransmission and the second packet is not.
==========

to

==========
Always take retransmissions into account when deciding pacing order

Retransmissions are supposed to be sent before normal packets by the pacer, but
the current implementation will only use it if the second packet is a
retransmission and the first packet is not. It misses the case where the first
packet is retransmission and the second packet is not.

This CL fixes the comparator and adds a unit test.

Also changed the SendAndExpectPacket function to propagate the retransmission
flag to the expectations. Previously, all packets were expected to be normal
packets.

BUG=webrtc:6124
==========

[terelius, 2016-07-19 12:50:14]

Please review the unit test carefully to verify that the behavior enforced by
the test is what we want.

[stefan-webrtc, 2016-07-20 08:31:20]

Good catch! lgtm

[pbos-webrtc, 2016-07-20 08:59:06]

lgtm

[terelius, 2016-07-20 09:13:50]

The CQ bit was checked by terelius@webrtc.org

[commit-bot: I haz the power, 2016-07-20 09:13:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-20 10:36:24]

Description was changed from

==========
Always take retransmissions into account when deciding pacing order

Retransmissions are supposed to be sent before normal packets by the pacer, but
the current implementation will only use it if the second packet is a
retransmission and the first packet is not. It misses the case where the first
packet is retransmission and the second packet is not.

This CL fixes the comparator and adds a unit test.

Also changed the SendAndExpectPacket function to propagate the retransmission
flag to the expectations. Previously, all packets were expected to be normal
packets.

BUG=webrtc:6124
==========

to

==========
Always take retransmissions into account when deciding pacing order

Retransmissions are supposed to be sent before normal packets by the pacer, but
the current implementation will only use it if the second packet is a
retransmission and the first packet is not. It misses the case where the first
packet is retransmission and the second packet is not.

This CL fixes the comparator and adds a unit test.

Also changed the SendAndExpectPacket function to propagate the retransmission
flag to the expectations. Previously, all packets were expected to be normal
packets.

BUG=webrtc:6124
==========

[commit-bot: I haz the power, 2016-07-20 10:36:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-20 10:36:36]

Description was changed from

==========
Always take retransmissions into account when deciding pacing order

Retransmissions are supposed to be sent before normal packets by the pacer, but
the current implementation will only use it if the second packet is a
retransmission and the first packet is not. It misses the case where the first
packet is retransmission and the second packet is not.

This CL fixes the comparator and adds a unit test.

Also changed the SendAndExpectPacket function to propagate the retransmission
flag to the expectations. Previously, all packets were expected to be normal
packets.

BUG=webrtc:6124
==========

to

==========
Always take retransmissions into account when deciding pacing order

Retransmissions are supposed to be sent before normal packets by the pacer, but
the current implementation will only use it if the second packet is a
retransmission and the first packet is not. It misses the case where the first
packet is retransmission and the second packet is not.

This CL fixes the comparator and adds a unit test.

Also changed the SendAndExpectPacket function to propagate the retransmission
flag to the expectations. Previously, all packets were expected to be normal
packets.

BUG=webrtc:6124

Committed: https://crrev.com/f39f7d931c11045fe0ba842e4eba9b816f0288ca
Cr-Commit-Position: refs/heads/master@{#13502}
==========

[commit-bot: I haz the power, 2016-07-20 10:36:37]

Patchset 2 (id:??) landed as
https://crrev.com/f39f7d931c11045fe0ba842e4eba9b816f0288ca
Cr-Commit-Position: refs/heads/master@{#13502}