Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2155813003: [Chromoting] Remove screen saver logic out of ScreenCapturer implementations (Closed)

Created:
4 years, 5 months ago by Hzj_jie
Modified:
4 years, 5 months ago
Reviewers:
Sergey Ulanov, Jamie
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[Chromoting] Remove screen saver logic out of ScreenCapturer implementations After change https://codereview.chromium.org/2080723008/, chromoting hosts are using device::PowerSaveBlocker to block screen saver and suspend. So similar logic in ScreenCapturer are not useful, and should be removed. BUG=626839 Committed: https://crrev.com/2181078ca8d4130bc44c7f49b1ca37f684b72c4d Cr-Commit-Position: refs/heads/master@{#13491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -54 lines) Patch
M webrtc/modules/desktop_capture/screen_capturer_mac.mm View 4 chunks +0 lines, -31 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_directx.cc View 2 chunks +1 line, -9 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Hzj_jie
4 years, 5 months ago (2016-07-15 22:47:30 UTC) #3
Sergey Ulanov
lgtm
4 years, 5 months ago (2016-07-15 23:22:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2155813003/1
4 years, 5 months ago (2016-07-15 23:59:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-16 00:05:16 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-16 00:05:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2181078ca8d4130bc44c7f49b1ca37f684b72c4d
Cr-Commit-Position: refs/heads/master@{#13491}

Powered by Google App Engine
This is Rietveld 408576698