Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2154693002: Fix inconsistent setting of the rtc_include_unittests flag. (Closed)

Created:
4 years, 5 months ago by phoglund
Modified:
4 years, 5 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix inconsistent setting of the rtc_include_unittests flag. On advice from brettw, se discussion here: https://codereview.webrtc.org/2149543002/ The problem was we were setting the flag to both false and true, and the the true happened to win out for WebRTC checkouts and false for Chromium checkouts. This change should make this mechanic more obvious. This change _should_ have no effect downstream. Doing tbr to see if we can get the chromium import back into a good state today. TBR=tommi@webrtc.org Committed: https://crrev.com/9d34148714773339a4e8396bd28aceb571554d36 Cr-Commit-Position: refs/heads/master@{#13484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M build_overrides/webrtc.gni View 1 chunk +5 lines, -2 lines 0 comments Download
M webrtc/build/webrtc.gni View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2154693002/1
4 years, 5 months ago (2016-07-15 10:54:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 10:56:11 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9d34148714773339a4e8396bd28aceb571554d36 Cr-Commit-Position: refs/heads/master@{#13484}
4 years, 5 months ago (2016-07-15 10:56:21 UTC) #10
phoglund
4 years, 5 months ago (2016-07-15 11:13:07 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2150293002/ by phoglund@webrtc.org.

The reason for reverting is: Nope, breaks chromium.

Powered by Google App Engine
This is Rietveld 408576698