Disable broken Android rtc_unittests.

Disable broken Android rtc_unittests.

After disabling all of these, the rest of the tests pass, at least on
my Nexus 7 device.

BUG=webrtc:4364
Committed: https://crrev.com/bb738733ea2d6c9e36e1cd0067fe12a3eae75da4
Cr-Commit-Position: refs/heads/master@{#13485}

[phoglund, 2016-07-14 11:57:54]

phoglund@webrtc.org changed reviewers:
+ tommi@webrtc.org

[pbos-webrtc, 2016-07-14 12:02:17]

pbos@webrtc.org changed reviewers:
+ pbos@webrtc.org

[pbos-webrtc, 2016-07-14 12:02:18]

https://codereview.webrtc.org/2151823002/diff/1/webrtc/base/filerotatingstrea...
File webrtc/base/filerotatingstream_unittest.cc (right):

https://codereview.webrtc.org/2151823002/diff/1/webrtc/base/filerotatingstrea...
webrtc/base/filerotatingstream_unittest.cc:29: class
MAYBE_FileRotatingStreamTest : public ::testing::Test {
You should disable the test and not the class of tests, right? E.g. MAYBE_State,
MAYBE_EmptyWrite and MAYBE_WriteAndRead instead of MAYBE_FileRotatingStreamTest.

[tommi, 2016-07-14 12:14:13]

https://codereview.webrtc.org/2151823002/diff/1/webrtc/base/filerotatingstrea...
File webrtc/base/filerotatingstream_unittest.cc (right):

https://codereview.webrtc.org/2151823002/diff/1/webrtc/base/filerotatingstrea...
webrtc/base/filerotatingstream_unittest.cc:270:
TEST_F(DISABLED_CallSessionFileRotatingStreamTest, WriteAndReadSmall) {
Disabled for all?

https://codereview.webrtc.org/2151823002/diff/1/webrtc/base/filerotatingstrea...
webrtc/base/filerotatingstream_unittest.cc:283:
TEST_F(DISABLED_CallSessionFileRotatingStreamTest, WriteAndReadLarge) {
too?

https://codereview.webrtc.org/2151823002/diff/1/webrtc/base/filerotatingstrea...
webrtc/base/filerotatingstream_unittest.cc:310:
TEST_F(DISABLED_CallSessionFileRotatingStreamTest, WriteAndReadFirstHalf) {
ditto

[phoglund, 2016-07-14 15:16:28]

PTAL

https://codereview.webrtc.org/2151823002/diff/1/webrtc/base/filerotatingstrea...
File webrtc/base/filerotatingstream_unittest.cc (right):

https://codereview.webrtc.org/2151823002/diff/1/webrtc/base/filerotatingstrea...
webrtc/base/filerotatingstream_unittest.cc:29: class
MAYBE_FileRotatingStreamTest : public ::testing::Test {
On 2016/07/14 12:02:18, pbos-webrtc wrote:
> You should disable the test and not the class of tests, right? E.g.
MAYBE_State,
> MAYBE_EmptyWrite and MAYBE_WriteAndRead instead of
MAYBE_FileRotatingStreamTest.

Mnyeh, all of them are broken anyway and it's quite possible it's a class-wide
problem, so this was less work.

https://codereview.webrtc.org/2151823002/diff/1/webrtc/base/filerotatingstrea...
webrtc/base/filerotatingstream_unittest.cc:270:
TEST_F(DISABLED_CallSessionFileRotatingStreamTest, WriteAndReadSmall) {
On 2016/07/14 12:14:13, tommi-webrtc wrote:
> Disabled for all?

Done.

https://codereview.webrtc.org/2151823002/diff/1/webrtc/base/filerotatingstrea...
webrtc/base/filerotatingstream_unittest.cc:283:
TEST_F(DISABLED_CallSessionFileRotatingStreamTest, WriteAndReadLarge) {
On 2016/07/14 12:14:13, tommi-webrtc wrote:
> too?

Done.

https://codereview.webrtc.org/2151823002/diff/1/webrtc/base/filerotatingstrea...
webrtc/base/filerotatingstream_unittest.cc:310:
TEST_F(DISABLED_CallSessionFileRotatingStreamTest, WriteAndReadFirstHalf) {
On 2016/07/14 12:14:13, tommi-webrtc wrote:
> ditto

Done.

[tommi, 2016-07-14 15:30:28]

lgtm

[phoglund, 2016-07-14 15:33:07]

https://codereview.webrtc.org/2151823002/diff/1/webrtc/base/filerotatingstrea...
File webrtc/base/filerotatingstream_unittest.cc (right):

https://codereview.webrtc.org/2151823002/diff/1/webrtc/base/filerotatingstrea...
webrtc/base/filerotatingstream_unittest.cc:29: class
MAYBE_FileRotatingStreamTest : public ::testing::Test {
On 2016/07/14 15:16:27, phoglund wrote:
> On 2016/07/14 12:02:18, pbos-webrtc wrote:
> > You should disable the test and not the class of tests, right? E.g.
> MAYBE_State,
> > MAYBE_EmptyWrite and MAYBE_WriteAndRead instead of
> MAYBE_FileRotatingStreamTest.
> 
> Mnyeh, all of them are broken anyway and it's quite possible it's a class-wide
> problem, so this was less work.

I should add: the two ways of doing it has the same effect, but it has the
drawback of being more work in case someone wants to enable just one of the
tests I disabled. Since all tests were broken I believe it's an issue on the
class level, so I think it's appropriate to disable the class here.

[phoglund, 2016-07-15 10:21:43]

The CQ bit was checked by phoglund@webrtc.org

[commit-bot: I haz the power, 2016-07-15 10:21:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-15 10:57:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-15 10:57:25]

Description was changed from

==========
Disable broken Android rtc_unittests.

After disabling all of these, the rest of the tests pass, at least on
my Nexus 7 device.

BUG=webrtc:4364
==========

to

==========
Disable broken Android rtc_unittests.

After disabling all of these, the rest of the tests pass, at least on
my Nexus 7 device.

BUG=webrtc:4364

Committed: https://crrev.com/bb738733ea2d6c9e36e1cd0067fe12a3eae75da4
Cr-Commit-Position: refs/heads/master@{#13485}
==========

[commit-bot: I haz the power, 2016-07-15 10:57:28]

Patchset 2 (id:??) landed as
https://crrev.com/bb738733ea2d6c9e36e1cd0067fe12a3eae75da4
Cr-Commit-Position: refs/heads/master@{#13485}