Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2151453002: Revert of WebRtcVoiceEngine: Use AudioDecoderFactory to generate recv codecs. (Closed)

Created:
4 years, 5 months ago by ossu
Modified:
4 years, 5 months ago
Reviewers:
ivoc, tlegrand-webrtc, tommi
CC:
webrtc-reviews_webrtc.org, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of WebRtcVoiceEngine: Use AudioDecoderFactory to generate recv codecs. (patchset #10 id:200001 of https://codereview.webrtc.org/2072753002/ ) Reason for revert: For some reason, payload_type_mapper.cc is not being picked up in Chrome builds, leading to undefined references. Reverting while investigating. Original issue's description: > WebRtcVoiceEngine: Use AudioDecoderFactory to generate recv codecs. > > Changed WebRtcVoiceEngine to present receive codecs from the formats > provided by its decoder factory. Added supported formats to > BuiltinAudioDecoderFactory. Added helper functions for creating some > simple decoder factories for mocking. > > Created a PayloadTypeMapper for assigning payload types to formats. I > think we'll eventually want to use this further up, or possibly in > both the audio and video sides. It would be best if the engines didn't > have to talk payload types at all, but it might be more difficult to > get around when payload types depend on each-other, like the RTX > codecs for video. > > This CL also includes some changes to rtc::Optional. I've put them in > a separate CL that should (or should not) land first, making these > changes void. > See: https://codereview.webrtc.org/2072713002/ > > BUG=webrtc:5805 > > Committed: https://crrev.com/95eb1ba0db79d8fd134ae61b0a24648598684e8a > Cr-Commit-Position: refs/heads/master@{#13459} TBR=ivoc@webrtc.org,tina.legrand@webrtc.org,tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5805 Committed: https://crrev.com/f93be584f740854a14a752e5c39947b4ffabd7e5 Cr-Commit-Position: refs/heads/master@{#13460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -542 lines) Patch
M webrtc/media/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/media/engine/nullwebrtcvideoengine_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
D webrtc/media/engine/payload_type_mapper.h View 1 chunk +0 lines, -54 lines 0 comments Download
D webrtc/media/engine/payload_type_mapper.cc View 1 chunk +0 lines, -159 lines 0 comments Download
D webrtc/media/engine/payload_type_mapper_unittest.cc View 1 chunk +0 lines, -162 lines 0 comments Download
M webrtc/media/engine/webrtcmediaengine.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.h View 2 chunks +1 line, -4 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 6 chunks +6 lines, -70 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 7 chunks +21 lines, -17 lines 0 comments Download
M webrtc/media/media.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.cc View 1 chunk +1 line, -25 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/mock/mock_audio_decoder_factory.h View 2 chunks +0 lines, -40 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ossu
Created Revert of WebRtcVoiceEngine: Use AudioDecoderFactory to generate recv codecs.
4 years, 5 months ago (2016-07-13 13:31:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2151453002/1
4 years, 5 months ago (2016-07-13 13:31:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 13:31:35 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 13:31:37 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 13:31:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f93be584f740854a14a752e5c39947b4ffabd7e5
Cr-Commit-Position: refs/heads/master@{#13460}

Powered by Google App Engine
This is Rietveld 408576698