Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2151433002: Avoid race in Call destructor (Closed)

Created:
4 years, 5 months ago by sprang_webrtc
Modified:
4 years, 5 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, pbos-webrtc, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Avoid race in Call destructor Don't update histograms until we're sure process threads won't call into the instance being destructed, trying to update stats. BUG=webrtc:6103 Committed: https://crrev.com/6d6122b46122ca45873383581a0eca8f616165ca Cr-Commit-Position: refs/heads/master@{#13461}

Patch Set 1 #

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M webrtc/call/call.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
sprang_webrtc
4 years, 5 months ago (2016-07-13 12:32:04 UTC) #2
pbos-webrtc
lgtm, but add a comment so this stays in place in the future
4 years, 5 months ago (2016-07-13 12:38:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2151433002/20001
4 years, 5 months ago (2016-07-13 12:43:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 13:37:13 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 13:37:20 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6d6122b46122ca45873383581a0eca8f616165ca
Cr-Commit-Position: refs/heads/master@{#13461}

Powered by Google App Engine
This is Rietveld 408576698