Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2150843003: Revert of Switch to use SequencedTaskChecker instead of ThreadChecker where needed. (Closed)

Created:
4 years, 5 months ago by perkj_webrtc
Modified:
4 years, 5 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Switch to use SequencedTaskChecker instead of ThreadChecker where needed. (patchset #1 id:1 of https://codereview.webrtc.org/2149553002/ ) Reason for revert: Breaks Chrome FYI https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/8187/steps/compile/logs/stdio Original issue's description: > Switch to use SequencedTaskChecker instead of ThreadChecker where needed. > This cl is in preparation for https://codereview.webrtc.org/2060403002/ Add task queue to Call. > In the coming cl the video_sender, and i420_buffer_pool will be used on a task queue and therefore SequencedTaskChecker is needed instead of a ThreadChecker. > > BUG=webrtc:5687 > > Committed: https://crrev.com/ec7cef854d85be2d9fd5b1a4e2c59a67feb662eb > Cr-Commit-Position: refs/heads/master@{#13474} TBR=tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5687 Committed: https://crrev.com/efd902cb1d9bbd81247a3e168f2080beae761d78 Cr-Commit-Position: refs/heads/master@{#13475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M webrtc/common_video/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_video/common_video.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_video/i420_buffer_pool.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/common_video/include/i420_buffer_pool.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_coding.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_sender.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
perkj_webrtc
Created Revert of Switch to use SequencedTaskChecker instead of ThreadChecker where needed.
4 years, 5 months ago (2016-07-14 09:33:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2150843003/1
4 years, 5 months ago (2016-07-14 09:33:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 09:33:25 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 09:33:27 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 09:33:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efd902cb1d9bbd81247a3e168f2080beae761d78
Cr-Commit-Position: refs/heads/master@{#13475}

Powered by Google App Engine
This is Rietveld 408576698