Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2150293002: Revert of Fix inconsistent setting of the rtc_include_unittests flag. (Closed)

Created:
4 years, 5 months ago by phoglund
Modified:
4 years, 5 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Fix inconsistent setting of the rtc_include_unittests flag. (patchset #1 id:1 of https://codereview.webrtc.org/2154693002/ ) Reason for revert: Nope, breaks chromium Original issue's description: > Fix inconsistent setting of the rtc_include_unittests flag. > > On advice from brettw, se discussion here: > https://codereview.webrtc.org/2149543002/ > > The problem was we were setting the flag to both false and true, > and the the true happened to win out for WebRTC checkouts and > false for Chromium checkouts. This change should make this > mechanic more obvious. > > This change _should_ have no effect downstream. > > Doing tbr to see if we can get the chromium import back into a good state today. > > TBR=tommi@webrtc.org > > Committed: https://crrev.com/9d34148714773339a4e8396bd28aceb571554d36 > Cr-Commit-Position: refs/heads/master@{#13484} TBR=tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/136778252d2896021dbe7146c36879c1185027db Cr-Commit-Position: refs/heads/master@{#13486}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M build_overrides/webrtc.gni View 1 chunk +2 lines, -5 lines 0 comments Download
M webrtc/build/webrtc.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
phoglund
Created Revert of Fix inconsistent setting of the rtc_include_unittests flag.
4 years, 5 months ago (2016-07-15 11:13:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2150293002/1
4 years, 5 months ago (2016-07-15 11:13:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 11:13:27 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 11:13:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/136778252d2896021dbe7146c36879c1185027db
Cr-Commit-Position: refs/heads/master@{#13486}

Powered by Google App Engine
This is Rietveld 408576698