Roll chromium_revision bfec2ff09d..dfc9cd81d9 (404886:405110)

Roll chromium_revision bfec2ff09d..dfc9cd81d9 (404886:405110)

Change log: https://chromium.googlesource.com/chromium/src/+log/bfec2ff09d..dfc9cd81d9
Full diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..dfc9cd81d9

Changed dependencies:
* src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/aa47d9773d..924d50ecae
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/95c69563dc..10f97f3bfc
* src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/bac4680ec9..e7079f0e0e
DEPS diff: https://chromium.googlesource.com/chromium/src/+/bfec2ff09d..dfc9cd81d9/DEPS

No update to Clang.

TBR=

[buildbot, 2016-07-13 10:04:57]

The CQ bit was checked by buildbot@webrtc.org

[commit-bot: I haz the power, 2016-07-13 10:05:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-13 10:07:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 10:07:30]

Try jobs failed on following builders:
  ios64_gn_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gn_dbg/builds/1172)
  mac_gn_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/4631)
  mac_gn_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_rel/builds/10843)

[brettw, 2016-07-14 16:26:16]

Your build is declaring the same value twice in different places with different
values. It's actually surprising you weren't getting an error before. This roll
may have accidentally fixed a bug in detecting this collision.

What it looks like you want to do is to delete the "rtc_include_tests = false"
line from webrtc/build/webrtc.gni.

And replace the rtc_include_tests line in build_overrides/webrtc.gni with:
declare_args() {
  rtc_include_tests = true
}

This will make the value always true for webrtc builds, keep it false when
compiled pulled into Chrome, and additionally allow overriding from the command
line for webrtc standalone builds. It looks like this is the intent.

[phoglund, 2016-07-15 11:25:44]

On 2016/07/14 16:26:16, brettw (ping after 24h) wrote:
> Your build is declaring the same value twice in different places with
different
> values. It's actually surprising you weren't getting an error before. This
roll
> may have accidentally fixed a bug in detecting this collision.
> 
> What it looks like you want to do is to delete the "rtc_include_tests = false"
> line from webrtc/build/webrtc.gni.
> 
> And replace the rtc_include_tests line in build_overrides/webrtc.gni with:
> declare_args() {
>   rtc_include_tests = true
> }
> 
> This will make the value always true for webrtc builds, keep it false when
> compiled pulled into Chrome, and additionally allow overriding from the
command
> line for webrtc standalone builds. It looks like this is the intent.

Didn't work, webrtc build is ok but chromium build says this:

E:\b\c\b\Win_Builder\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/webrtc/BUILD.gn:381:5: Undefined identifier
if (rtc_include_tests) {
    ^----------------
See //remoting/BUILD.gn:169:5: which caused the file to be included.
    "//third_party/webrtc",
    ^---------------------
GN gen failed: 1

I think it's because Chromium pulls in webrtc/build/webrtc.gni but it
doesn't pull in build_overrides/webrtc.gni, so it misses the declaration of
the variable.

Looks like we currently declare it as false and that WebRTC overrides makes
it true standalone WebRTC. Chromium goes with the default which means it will
be false. I suppose one way to solve it could be to make it true by default
instead and have Chromium override it to false? In that case, how do I do that
here in Chromium?
https://cs.chromium.org/chromium/src/third_party/webrtc/BUILD.gn?type=cs&q=/t...