Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2147973002: Update on my last compatibility fix for libevent2. (Closed)

Created:
4 years, 5 months ago by tommi
Modified:
4 years, 5 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update on my last compatibility fix for libevent2. This updates how we initialize timer events to be the same way as we initialize non-timer events. BUG= Committed: https://crrev.com/1666b61d0e375ffa1ddd10ac8617b6f53f35bd62 Cr-Commit-Position: refs/heads/master@{#13468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -16 lines) Patch
M webrtc/base/task_queue_libevent.cc View 3 chunks +23 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tommi
4 years, 5 months ago (2016-07-13 16:14:33 UTC) #2
henrika_webrtc
LGTM
4 years, 5 months ago (2016-07-13 16:17:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2147973002/1
4 years, 5 months ago (2016-07-13 17:56:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 17:58:16 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 17:58:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1666b61d0e375ffa1ddd10ac8617b6f53f35bd62
Cr-Commit-Position: refs/heads/master@{#13468}

Powered by Google App Engine
This is Rietveld 408576698