SurfaceViewRendererOnMeasureTest: Wait for frame size change to take effect

SurfaceViewRendererOnMeasureTest: Wait for frame size change to take effect

SurfaceViewRendererOnMeasureTest#testFrame1280x720 is currently flaky
because of a race. This issue was introduced here:
https://codereview.webrtc.org/2111933002/. That CL moved the function
updateFrameDimensionsAndReportEvents() from renderFrame() to
renderFrameOnRenderThread(). The OnMeasureTest currently just calls
renderFrame() with a new frame size and immediately starts testing the
measured size, which might be before renderFrameOnRenderThread() is
executed. This CL waits for the RendererEvents.onFrameResolutionChanged()
callback before starting the test to fix this race.

BUG=webrtc:6089
Committed: https://crrev.com/e5a246f69341007a69f5244acac86e218e341bfe
Cr-Commit-Position: refs/heads/master@{#13448}

[magjed_webrtc, 2016-07-12 13:02:55]

Description was changed from

==========
SurfaceViewRendererOnMeasureTest: Wait for frame size change to take effect

SurfaceViewRendererOnMeasureTest#testFrame1280x720 is currently flaky
because of a race. This issue was introduced here:
https://codereview.webrtc.org/2111933002/. That CL moved the function
updateFrameDimensionsAndReportEvents() from renderFrame() to
renderFrameOnRenderThread(). The OnMeasureTest currently just calls
renderFrame() with a new frame size and immediately starts testing the
measured size, which might be before renderFrameOnRenderThread() is
executed. This CL waits for the RendererEvents.onFrameResolutionChanged()
callback before starting the test to fix this race.

BUG=webrtc:6089
==========

to

==========
SurfaceViewRendererOnMeasureTest: Wait for frame size change to take effect

SurfaceViewRendererOnMeasureTest#testFrame1280x720 is currently flaky
because of a race. This issue was introduced here:
https://codereview.webrtc.org/2111933002/. That CL moved the function
updateFrameDimensionsAndReportEvents() from renderFrame() to
renderFrameOnRenderThread(). The OnMeasureTest currently just calls
renderFrame() with a new frame size and immediately starts testing the
measured size, which might be before renderFrameOnRenderThread() is
executed. This CL waits for the RendererEvents.onFrameResolutionChanged()
callback before starting the test to fix this race.

BUG=webrtc:6089
==========

[magjed_webrtc, 2016-07-12 13:02:55]

magjed@webrtc.org changed reviewers:
+ perkj@webrtc.org

[magjed_webrtc, 2016-07-12 13:03:05]

perkj - please take a look.

[perkj_webrtc, 2016-07-12 14:04:37]

lgtm

https://codereview.webrtc.org/2147463002/diff/1/webrtc/api/androidtests/src/o...
File
webrtc/api/androidtests/src/org/webrtc/SurfaceViewRendererOnMeasureTest.java
(right):

https://codereview.webrtc.org/2147463002/diff/1/webrtc/api/androidtests/src/o...
webrtc/api/androidtests/src/org/webrtc/SurfaceViewRendererOnMeasureTest.java:119:
* Mock renderer evets with blocking wait functionality for frame size changes.
s events

[magjed_webrtc, 2016-07-12 14:06:10]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2016-07-12 14:06:10]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2147463002/#ps20001 (title:
"fix spelling error")

[commit-bot: I haz the power, 2016-07-12 14:06:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-12 14:48:20]

Description was changed from

==========
SurfaceViewRendererOnMeasureTest: Wait for frame size change to take effect

SurfaceViewRendererOnMeasureTest#testFrame1280x720 is currently flaky
because of a race. This issue was introduced here:
https://codereview.webrtc.org/2111933002/. That CL moved the function
updateFrameDimensionsAndReportEvents() from renderFrame() to
renderFrameOnRenderThread(). The OnMeasureTest currently just calls
renderFrame() with a new frame size and immediately starts testing the
measured size, which might be before renderFrameOnRenderThread() is
executed. This CL waits for the RendererEvents.onFrameResolutionChanged()
callback before starting the test to fix this race.

BUG=webrtc:6089
==========

to

==========
SurfaceViewRendererOnMeasureTest: Wait for frame size change to take effect

SurfaceViewRendererOnMeasureTest#testFrame1280x720 is currently flaky
because of a race. This issue was introduced here:
https://codereview.webrtc.org/2111933002/. That CL moved the function
updateFrameDimensionsAndReportEvents() from renderFrame() to
renderFrameOnRenderThread(). The OnMeasureTest currently just calls
renderFrame() with a new frame size and immediately starts testing the
measured size, which might be before renderFrameOnRenderThread() is
executed. This CL waits for the RendererEvents.onFrameResolutionChanged()
callback before starting the test to fix this race.

BUG=webrtc:6089
==========

[commit-bot: I haz the power, 2016-07-12 14:48:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-12 14:48:25]

Description was changed from

==========
SurfaceViewRendererOnMeasureTest: Wait for frame size change to take effect

SurfaceViewRendererOnMeasureTest#testFrame1280x720 is currently flaky
because of a race. This issue was introduced here:
https://codereview.webrtc.org/2111933002/. That CL moved the function
updateFrameDimensionsAndReportEvents() from renderFrame() to
renderFrameOnRenderThread(). The OnMeasureTest currently just calls
renderFrame() with a new frame size and immediately starts testing the
measured size, which might be before renderFrameOnRenderThread() is
executed. This CL waits for the RendererEvents.onFrameResolutionChanged()
callback before starting the test to fix this race.

BUG=webrtc:6089
==========

to

==========
SurfaceViewRendererOnMeasureTest: Wait for frame size change to take effect

SurfaceViewRendererOnMeasureTest#testFrame1280x720 is currently flaky
because of a race. This issue was introduced here:
https://codereview.webrtc.org/2111933002/. That CL moved the function
updateFrameDimensionsAndReportEvents() from renderFrame() to
renderFrameOnRenderThread(). The OnMeasureTest currently just calls
renderFrame() with a new frame size and immediately starts testing the
measured size, which might be before renderFrameOnRenderThread() is
executed. This CL waits for the RendererEvents.onFrameResolutionChanged()
callback before starting the test to fix this race.

BUG=webrtc:6089

Committed: https://crrev.com/e5a246f69341007a69f5244acac86e218e341bfe
Cr-Commit-Position: refs/heads/master@{#13448}
==========

[commit-bot: I haz the power, 2016-07-12 14:48:25]

Patchset 2 (id:??) landed as
https://crrev.com/e5a246f69341007a69f5244acac86e218e341bfe
Cr-Commit-Position: refs/heads/master@{#13448}