Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2147453002: Revert of Visualization tool for WebrtcEventLogs (Closed)

Created:
4 years, 5 months ago by terelius
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Visualization tool for WebrtcEventLogs (patchset #9 id:160001 of https://codereview.webrtc.org/1995523002/ ) Reason for revert: Reverting while investigating a downstream build failure. Original issue's description: > Initial version of the local visualization tool for WebrtcEventLogs. > > Plot graphs to python code. Generate packet, playout, sequence number and total bitrate graphs. > > Add bitrate and latency plots. Generate multiple figures, and control which ones are used through command line flags. > > Committed: https://crrev.com/a478786ef1513790194792010f766324a469db4d > Cr-Commit-Position: refs/heads/master@{#13443} TBR=stefan@webrtc.org,aleloi@webrtc.org,phoglund@webrtc.org,henrika@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a44f28da45526346da5b7e8c7e894dc4f26bc66f Cr-Commit-Position: refs/heads/master@{#13445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1181 lines) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/BUILD.gn View 1 chunk +0 lines, -30 lines 0 comments Download
M webrtc/tools/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/tools/event_log_visualizer/analyzer.h View 1 chunk +0 lines, -65 lines 0 comments Download
D webrtc/tools/event_log_visualizer/analyzer.cc View 1 chunk +0 lines, -710 lines 0 comments Download
D webrtc/tools/event_log_visualizer/generate_timeseries.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D webrtc/tools/event_log_visualizer/plot_base.h View 1 chunk +0 lines, -78 lines 0 comments Download
D webrtc/tools/event_log_visualizer/plot_python.h View 1 chunk +0 lines, -36 lines 0 comments Download
D webrtc/tools/event_log_visualizer/plot_python.cc View 1 chunk +0 lines, -98 lines 0 comments Download
M webrtc/tools/tools.gyp View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
terelius
Created Revert of Visualization tool for WebrtcEventLogs
4 years, 5 months ago (2016-07-12 12:11:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2147453002/1
4 years, 5 months ago (2016-07-12 12:11:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 12:11:25 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 12:11:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a44f28da45526346da5b7e8c7e894dc4f26bc66f
Cr-Commit-Position: refs/heads/master@{#13445}

Powered by Google App Engine
This is Rietveld 408576698