Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2147443002: Clean up unused cricket::VideoCapturer inclusion from mediaengine.h (Closed)

Created:
4 years, 5 months ago by perkj_webrtc
Modified:
4 years, 5 months ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Clean up unused cricket::VideoCapturer inclusion from mediaengine.h TBR=nisse@webrtc.org BUG=webrtc:5426 Committed: https://crrev.com/1e56991f248f8235c69cb3d95b35a44389c48354 Cr-Commit-Position: refs/heads/master@{#13446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M webrtc/media/base/mediaengine.h View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
perkj_webrtc
4 years, 5 months ago (2016-07-12 12:02:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2147443002/1
4 years, 5 months ago (2016-07-12 12:02:56 UTC) #3
perkj_webrtc
Committed patchset #1 (id:1) manually as 1e56991f248f8235c69cb3d95b35a44389c48354 (presubmit successful).
4 years, 5 months ago (2016-07-12 12:25:30 UTC) #5
perkj_webrtc
4 years, 5 months ago (2016-07-12 12:54:09 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2142893002/ by perkj@webrtc.org.

The reason for reverting is: Breaks up stream projects..

Powered by Google App Engine
This is Rietveld 408576698