Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: webrtc/video/video_receive_stream.cc

Issue 2146883002: Avoid race in VideoReceiveStream shutdown (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: JitterBuffer not resetting frame buffers on Stop Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/video_receive_stream.cc
diff --git a/webrtc/video/video_receive_stream.cc b/webrtc/video/video_receive_stream.cc
index ad9beb35e75384801cf03d264f935a7137a9b383..2ddec191807257d2d98dc48e2fa34aa240273403 100644
--- a/webrtc/video/video_receive_stream.cc
+++ b/webrtc/video/video_receive_stream.cc
@@ -267,7 +267,7 @@ void VideoReceiveStream::Start() {
void VideoReceiveStream::Stop() {
rtp_stream_receiver_.StopReceive();
- video_receiver_.TriggerDecoderShutdown();
+ video_receiver_.TriggerDecoderShutdown(); // Releases waiting decoder thread.
pbos-webrtc 2016/07/13 16:43:05 Put something to the effect of this making decode_
sprang_webrtc 2016/07/13 16:51:32 Done.
decode_thread_.Stop();
call_stats_->DeregisterStatsObserver(video_stream_decoder_.get());
video_stream_decoder_.reset();
« webrtc/modules/video_coding/jitter_buffer.cc ('K') | « webrtc/modules/video_coding/jitter_buffer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698