Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2145973003: Create empty PayloadTypeMapper files and add them to builds. (Closed)

Created:
4 years, 5 months ago by ossu
Modified:
4 years, 5 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Create empty PayloadTypeMapper files and add them to builds. This is related to https://codereview.webrtc.org/2072753002/ and its eventual revert. That change required changes in chromium's build files to not break it. Those build changes cannot be made before these new files are available. TBR=tommi@webrtc.org Committed: https://crrev.com/6f06cca96f39ee8b6254137c9691637b9b6aaee0 Cr-Commit-Position: refs/heads/master@{#13466}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M webrtc/media/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + webrtc/media/engine/payload_type_mapper.h View 1 chunk +4 lines, -7 lines 0 comments Download
A + webrtc/media/engine/payload_type_mapper.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M webrtc/media/media.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
ossu
Hey! Turns out my previous CL upset chromium (libjingle specifically). I've put together this CL ...
4 years, 5 months ago (2016-07-13 17:04:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2145973003/1
4 years, 5 months ago (2016-07-13 17:04:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 17:06:26 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 17:06:38 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f06cca96f39ee8b6254137c9691637b9b6aaee0
Cr-Commit-Position: refs/heads/master@{#13466}

Powered by Google App Engine
This is Rietveld 408576698