Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2145613006: Fix VideoFrame inclusion in mediastreaminterface.h (Closed)

Created:
4 years, 5 months ago by perkj_webrtc
Modified:
4 years, 5 months ago
Reviewers:
tommi
CC:
tterriberry_mozilla.com, webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix VideoFrame inclusion in mediastreaminterface.h This cl clean up unused forward declaration of cricket::AudioFrame and cricket::Renderer. cricket::VideoFrame is used in the interface and thus the header file is included. BUG=webrtc:5687 Committed: https://crrev.com/5d5833370f7c921899f557fec8a0f2a659901a5a Cr-Commit-Position: refs/heads/master@{#13477}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M webrtc/api/mediastreaminterface.h View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
perkj_webrtc
Can you please help review this cl? It should unblock an import.
4 years, 5 months ago (2016-07-14 12:16:11 UTC) #2
tommi
lgtm
4 years, 5 months ago (2016-07-14 14:06:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2145613006/1
4 years, 5 months ago (2016-07-14 14:12:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 14:14:31 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 14:14:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d5833370f7c921899f557fec8a0f2a659901a5a
Cr-Commit-Position: refs/heads/master@{#13477}

Powered by Google App Engine
This is Rietveld 408576698