Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2143123003: Revert of Clean up unused cricket::VideoCapturer inclusion from mediaengine.h (Closed)

Created:
4 years, 5 months ago by perkj_webrtc
Modified:
4 years, 5 months ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Clean up unused cricket::VideoCapturer inclusion from mediaengine.h (patchset #1 id:1 of https://codereview.webrtc.org/2149533002/ ) Reason for revert: Still broken- but different place. Original issue's description: > Reland of Clean up unused cricket::VideoCapturer inclusion from mediaengine.h (patchset #1 id:1 of https://codereview.webrtc.org/2142893002/ ) > > Reason for revert: > Upstream fixed. > > Original issue's description: > > Revert of Clean up unused cricket::VideoCapturer inclusion from mediaengine.h (patchset #1 id:1 of https://codereview.webrtc.org/2147443002/ ) > > > > Reason for revert: > > Breaks up stream projects. > > > > Original issue's description: > > > Clean up unused cricket::VideoCapturer inclusion from mediaengine.h > > > > > > TBR=nisse@webrtc.org > > > BUG=webrtc:5426 > > > > > > Committed: https://crrev.com/1e56991f248f8235c69cb3d95b35a44389c48354 > > > Cr-Commit-Position: refs/heads/master@{#13446} > > > > TBR=nisse@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:5426 > > > > Committed: https://crrev.com/3a9f41e584953226e43bf312ec59d625c97cfd62 > > Cr-Commit-Position: refs/heads/master@{#13447} > > TBR=nisse@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5426 > > Committed: https://crrev.com/e03c1618152824a980664536a64bc29d63740ad7 > Cr-Commit-Position: refs/heads/master@{#13456} TBR=nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5426 Committed: https://crrev.com/7470eb7977c153d2a512f8376601b15c6266fa25 Cr-Commit-Position: refs/heads/master@{#13458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/media/base/mediaengine.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
perkj_webrtc
Created Revert of Clean up unused cricket::VideoCapturer inclusion from mediaengine.h
4 years, 5 months ago (2016-07-13 10:02:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2143123003/1
4 years, 5 months ago (2016-07-13 10:03:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 10:03:07 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7470eb7977c153d2a512f8376601b15c6266fa25 Cr-Commit-Position: refs/heads/master@{#13458}
4 years, 5 months ago (2016-07-13 10:03:16 UTC) #6
perkj_webrtc
4 years, 5 months ago (2016-07-14 07:58:22 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2151693004/ by perkj@webrtc.org.

The reason for reverting is: And a new attempt..

Powered by Google App Engine
This is Rietveld 408576698