Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2142813002: Report Unique_frames_count from frame_analyzer using 'score' units. (Closed)

Created:
4 years, 5 months ago by brandtr
Modified:
4 years, 5 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Report Unique_frames_count from frame_analyzer using 'score' units. With this change, an increase in Unique_frames_count will be marked as an improvement (rather than a deterioration) in the Chrome Performance Dashboard. BUG=chromium:623521 R=phoglund@webrtc.org Committed: https://crrev.com/d658edeeedf1efd50a373f0ec90dfd54ce955527 Cr-Commit-Position: refs/heads/master@{#13444}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/tools/frame_analyzer/video_quality_analysis.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
brandtr
4 years, 5 months ago (2016-07-12 10:30:11 UTC) #1
phoglund
lgtm
4 years, 5 months ago (2016-07-12 11:41:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2142813002/1
4 years, 5 months ago (2016-07-12 11:47:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 11:53:08 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 11:53:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d658edeeedf1efd50a373f0ec90dfd54ce955527
Cr-Commit-Position: refs/heads/master@{#13444}

Powered by Google App Engine
This is Rietveld 408576698