Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2141413002: Revert of Adds data logging in native AudioDeviceBuffer class (Closed)

Created:
4 years, 5 months ago by henrika_webrtc
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Adds data logging in native AudioDeviceBuffer class (patchset #1 id:1 of https://codereview.webrtc.org/2138403003/ ) Reason for revert: Reverting again since it might have caused this issue: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%28dbg%29%20%28L%20Nexus9%29/builds/13622/steps/content_browsertests/logs/stdio Original issue's description: > Reland of Adds data logging in native AudioDeviceBuffer class (patchset #1 id:1 of https://codereview.webrtc.org/2139233002/ ) > > Reason for revert: > My original patch broke things that are now fixed by https://codereview.webrtc.org/2141193002/. > > Hence I am relanding my original change. > > Original issue's description: > > Revert of Adds data logging in native AudioDeviceBuffer class (patchset #10 id:180001 of https://codereview.webrtc.org/2132613002/ ) > > > > Reason for revert: > > Seems to break things upstream. > > > > Original issue's description: > > > Adds data logging in native AudioDeviceBuffer class. > > > > > > Goal is to provide periodic logging of most essential audio parameters > > > for playout and recording sides. It will allow us to track if the native audio layer is working as intended. > > > > > > BUG=NONE > > > > > > Committed: https://crrev.com/348e411dd27e6dbe9b84b27ce46e9b7c657c1eae > > > Cr-Commit-Position: refs/heads/master@{#13440} > > > > TBR=stefan@webrtc.org,henrika@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=NONE > > > > Committed: https://crrev.com/025aa94ccb85e4c6fe20a3fecdac5d27ec9ba3da > > Cr-Commit-Position: refs/heads/master@{#13441} > > TBR=stefan@webrtc.org,sprang@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=NONE > > Committed: https://crrev.com/dd2fdecc78c50377d10ec98b41179acde9218ee7 > Cr-Commit-Position: refs/heads/master@{#13455} TBR=stefan@webrtc.org,sprang@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=NONE Committed: https://crrev.com/5dd941e5a5ccde541d9b40a1df379ed59c5fab5c Cr-Commit-Position: refs/heads/master@{#13457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -194 lines) Patch
M webrtc/modules/audio_device/audio_device_buffer.h View 3 chunks +5 lines, -65 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_buffer.cc View 15 chunks +34 lines, -129 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
henrika_webrtc
Created Revert of Adds data logging in native AudioDeviceBuffer class
4 years, 5 months ago (2016-07-13 09:32:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2141413002/1
4 years, 5 months ago (2016-07-13 09:32:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 09:32:43 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5dd941e5a5ccde541d9b40a1df379ed59c5fab5c Cr-Commit-Position: refs/heads/master@{#13457}
4 years, 5 months ago (2016-07-13 09:32:56 UTC) #7
henrika_webrtc
4 years, 5 months ago (2016-07-13 13:40:05 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2146853003/ by henrika@webrtc.org.

The reason for reverting is: Will make one more try since we have now confirmed
that our TaskQueue tests works on Android. Let's hope for the best....

Powered by Google App Engine
This is Rietveld 408576698