Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2141193002: Call event_assign() instead of event_set(), when available. (Closed)

Created:
4 years, 5 months ago by tommi
Modified:
4 years, 5 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Call event_assign() instead of event_set(), when available. event_set() has been deprecated and doesn't allow passing the main loop to be passed to initialize the event. event_assign() is the method to call in Event2 when available. However, we still need to be compatible with Chromium's version of libevent, so there's an #ifdef check in the meantime. BUG= Committed: https://crrev.com/7b020da9d7fc0740d14063f2be91712dfa7126f7 Cr-Commit-Position: refs/heads/master@{#13454}

Patch Set 1 #

Patch Set 2 : Don't set ev_base when using event_set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M webrtc/base/task_queue_libevent.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
tommi
Don't set ev_base when using event_set
4 years, 5 months ago (2016-07-12 20:47:26 UTC) #1
tommi
4 years, 5 months ago (2016-07-12 20:48:24 UTC) #3
henrika_webrtc
LGTM
4 years, 5 months ago (2016-07-13 07:50:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2141193002/20001
4 years, 5 months ago (2016-07-13 07:51:07 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 07:56:45 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 07:56:50 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b020da9d7fc0740d14063f2be91712dfa7126f7
Cr-Commit-Position: refs/heads/master@{#13454}

Powered by Google App Engine
This is Rietveld 408576698