Chromium Code Reviews

Issue 2141093002: Fixed ios build on case sensitivity file system (Closed)

Created:
4 years, 5 months ago by jacek.marchwicki
Modified:
4 years, 4 months ago
Reviewers:
braveyao1, tkchin_webrtc
CC:
niklas.enbom, peah-webrtc, qiang.lu, tterriberry_mozilla.com, webrtc-reviews_webrtc.org, yujie_mao (webrtc)
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixed ios build on case sensitivity file system When building ios bug on case-sensitive mac there were serveral problems with file names. This commit fiexes them. BUG=webrtc:6071

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Stats (+-2 lines, -182 lines)
M webrtc/build/ios/build_ios_libs.sh View 1 chunk +2 lines, -2 lines 0 comments
D webrtc/examples/objc/AppRTCDemo/RTCICECandidate+JSON.h View 1 chunk +0 lines, -22 lines 0 comments
D webrtc/examples/objc/AppRTCDemo/RTCICECandidate+JSON.m View 1 chunk +0 lines, -100 lines 0 comments
D webrtc/examples/objc/AppRTCDemo/RTCICEServer+JSON.h View 1 chunk +0 lines, -19 lines 0 comments
D webrtc/examples/objc/AppRTCDemo/RTCICEServer+JSON.m View 1 chunk +0 lines, -43 lines 0 comments
A + webrtc/examples/objc/AppRTCDemo/RTCIceCandidate+JSON.h View 0 chunks +-1 lines, --1 lines 0 comments
A + webrtc/examples/objc/AppRTCDemo/RTCIceCandidate+JSON.m View 0 chunks +-1 lines, --1 lines 0 comments
A + webrtc/examples/objc/AppRTCDemo/RTCIceServer+JSON.h View 0 chunks +-1 lines, --1 lines 0 comments
A + webrtc/examples/objc/AppRTCDemo/RTCIceServer+JSON.m View 0 chunks +-1 lines, --1 lines 0 comments

Messages

Total messages: 13 (5 generated)
jacek.marchwicki
4 years, 5 months ago (2016-07-12 15:56:37 UTC) #1
braveyao1
tkchin@, PTAL.
4 years, 5 months ago (2016-07-14 16:29:17 UTC) #7
jacek.marchwicki
On 2016/07/14 at 16:29:17, braveyao wrote: > tkchin@, PTAL. any results of review?
4 years, 4 months ago (2016-08-01 06:10:06 UTC) #8
tkchin_webrtc
thanks for ping lgtm can you rebase to head?
4 years, 4 months ago (2016-08-01 16:36:43 UTC) #9
jacek.marchwicki
On 2016/08/01 at 16:36:43, tkchin wrote: > thanks for ping > lgtm > can you ...
4 years, 4 months ago (2016-08-02 09:34:07 UTC) #10
tkchin_webrtc
On 2016/08/02 09:34:07, jacek.marchwicki wrote: > On 2016/08/01 at 16:36:43, tkchin wrote: > > thanks ...
4 years, 4 months ago (2016-08-02 17:05:16 UTC) #11
jacek.marchwicki
On 2016/08/02 at 17:05:16, tkchin wrote: > On 2016/08/02 09:34:07, jacek.marchwicki wrote: > > On ...
4 years, 4 months ago (2016-08-11 12:02:57 UTC) #12
jacek.marchwicki
4 years, 4 months ago (2016-08-11 12:12:34 UTC) #13
Message was sent while issue was closed.
On 2016/08/11 at 12:02:57, jacek.marchwicki wrote:
> On 2016/08/02 at 17:05:16, tkchin wrote:
> > On 2016/08/02 09:34:07, jacek.marchwicki wrote:
> > > On 2016/08/01 at 16:36:43, tkchin wrote:
> > > > thanks for ping
> > > > lgtm
> > > > can you rebase to head?
> > > 
> > > patchset uploaded
> > 
> > bot is still complaining about patch failure, something must've gone in
before you updated. Can you try again?
> 
> @tkchin Actually I don't understand why builds failed. They are red (here:
https://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/buil...)
but don't say whats gone wrong... or I just don't understand this UI. I'm not
familiar with webrtc CI.


@tkchin Oh.. i Se it's merged in current webrtc via
https://codereview.webrtc.org/2214113002/, thanks

Powered by Google App Engine