Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2139853002:
add convert_from.h include for ConvertFromI420 (Closed)
|
Created:
4 years, 5 months ago by fbarchard1 Modified:
4 years, 5 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
Descriptionadd convert_from.h include for ConvertFromI420
webrtc doesnt include the header that the function is prototyped in.
This CL makes the convert_from.h include those headers to allow webrtc to
update to the head libyuv.
R=marpan@webrtc.org,pbos@webrtc.org
BUG=libyuv:620, webrtc:6094
TESTED=local build and try bots
Committed: https://crrev.com/8c59617c5a14045f0a3db9e5841549c7d556f839
Cr-Commit-Position: refs/heads/master@{#13436}
Patch Set 1 #Patch Set 2 : Add #include libyuv/convert_from.h for ConvertFromI420() #Patch Set 3 : remove comment from webrtc/common_video/video_frame_buffer.cc #
Messages
Total messages: 25 (12 generated)
fbarchard@google.com changed reviewers: + marpan@webrtc.org
The function ConvertFromI420 is prototyped in the header libuyv/convert_from.h
braveyao@webrtc.org changed reviewers: + braveyao@webrtc.org, pbos@webrtc.org - braveyai@webrtc.org, marpan@webrtc.org
+ pbos@ as OWNER
lgtm. And need to correct my email address in description.
marpan@webrtc.org changed reviewers: + marpan@webrtc.org
lgtm
The CQ bit was checked by fbarchard@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6808)
Description was changed from ========== add convert_from.h include for ConvertFromI420 webrtc doesnt include the header that the function is prototyped in. This CL makes the convert_from.h include those headers to allow webrtc to update to the head libyuv. R=braveyai@webrtc.org BUG=libyuv:620,webrtc:6094 TESTED=local build and try bots ========== to ========== add convert_from.h include for ConvertFromI420 webrtc doesnt include the header that the function is prototyped in. This CL makes the convert_from.h include those headers to allow webrtc to update to the head libyuv. R=marpan@webrtc.org BUG=libyuv:620,webrtc:6094 TESTED=local build and try bots ==========
Description was changed from ========== add convert_from.h include for ConvertFromI420 webrtc doesnt include the header that the function is prototyped in. This CL makes the convert_from.h include those headers to allow webrtc to update to the head libyuv. R=marpan@webrtc.org BUG=libyuv:620,webrtc:6094 TESTED=local build and try bots ========== to ========== add convert_from.h include for ConvertFromI420 webrtc doesnt include the header that the function is prototyped in. This CL makes the convert_from.h include those headers to allow webrtc to update to the head libyuv. R=marpan@webrtc.org,pbos@webrtc.org BUG=libyuv:620,webrtc:6094 TESTED=local build and try bots ==========
fbarchard@google.com changed reviewers: + pthatcher@webrtc.org
Needs an owner approval
lgtm On 2016/07/12 00:06:46, fbarchard1 wrote: > Needs an owner approval
The CQ bit was checked by fbarchard@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from braveyao@webrtc.org, marpan@webrtc.org Link to the patchset: https://codereview.webrtc.org/2139853002/#ps40001 (title: "remove comment from webrtc/common_video/video_frame_buffer.cc")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== add convert_from.h include for ConvertFromI420 webrtc doesnt include the header that the function is prototyped in. This CL makes the convert_from.h include those headers to allow webrtc to update to the head libyuv. R=marpan@webrtc.org,pbos@webrtc.org BUG=libyuv:620,webrtc:6094 TESTED=local build and try bots ========== to ========== add convert_from.h include for ConvertFromI420 webrtc doesnt include the header that the function is prototyped in. This CL makes the convert_from.h include those headers to allow webrtc to update to the head libyuv. R=marpan@webrtc.org,pbos@webrtc.org BUG=libyuv:620,webrtc:6094 TESTED=local build and try bots ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== add convert_from.h include for ConvertFromI420 webrtc doesnt include the header that the function is prototyped in. This CL makes the convert_from.h include those headers to allow webrtc to update to the head libyuv. R=marpan@webrtc.org,pbos@webrtc.org BUG=libyuv:620,webrtc:6094 TESTED=local build and try bots ========== to ========== add convert_from.h include for ConvertFromI420 webrtc doesnt include the header that the function is prototyped in. This CL makes the convert_from.h include those headers to allow webrtc to update to the head libyuv. R=marpan@webrtc.org,pbos@webrtc.org BUG=libyuv:620,webrtc:6094 TESTED=local build and try bots Committed: https://crrev.com/8c59617c5a14045f0a3db9e5841549c7d556f839 Cr-Commit-Position: refs/heads/master@{#13436} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/8c59617c5a14045f0a3db9e5841549c7d556f839 Cr-Commit-Position: refs/heads/master@{#13436}
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
