Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 2139723003: Handle initialization race in TaskQueue on Windows, discovered by drmemory (Closed)

Created:
4 years, 5 months ago by tommi
Modified:
4 years, 5 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Handle initialization race in TaskQueue on Windows, discovered by drmemory. The issue was that if the main entry routine of the thread would get called before the first APC, the thread would hang on a GetMessage() call and the APC sent to initialize the thread, would never run. BUG= Committed: https://crrev.com/b89257a51b5363628e9d694584dc5a64da772809 Cr-Commit-Position: refs/heads/master@{#13438}

Patch Set 1 #

Patch Set 2 : Use QS_ALLEVENTS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -12 lines) Patch
M webrtc/base/task_queue.h View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/base/task_queue_win.cc View 1 4 chunks +25 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
tommi
Use QS_ALLEVENTS
4 years, 5 months ago (2016-07-11 20:10:43 UTC) #1
tommi
4 years, 5 months ago (2016-07-11 20:40:49 UTC) #4
tommi
On 2016/07/11 20:40:49, tommi-webrtc wrote: Hej Henrik - FYI, to be sure, I tested this ...
4 years, 5 months ago (2016-07-11 20:48:45 UTC) #5
henrika_webrtc
Looks great. Will use it in my patch and confirm that it works as well. ...
4 years, 5 months ago (2016-07-12 08:12:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2139723003/20001
4 years, 5 months ago (2016-07-12 08:19:22 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-12 08:24:41 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 08:24:47 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b89257a51b5363628e9d694584dc5a64da772809
Cr-Commit-Position: refs/heads/master@{#13438}

Powered by Google App Engine
This is Rietveld 408576698