Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm

Issue 2137223002: Prefix bool variable with "should". (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm
diff --git a/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm b/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm
index 74b5c5df83942ad13705cfd6f1cb5553b7bb9faf..c52b918b441a7928db2c3664359540cc12bc884d 100644
--- a/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm
+++ b/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm
@@ -33,8 +33,9 @@
_iceBackupCandidatePairPingInterval;
@synthesize keyType = _keyType;
@synthesize iceCandidatePoolSize = _iceCandidatePoolSize;
-@synthesize pruneTurnPorts = _pruneTurnPorts;
-@synthesize presumeWritableWhenFullyRelayed = _presumeWritableWhenFullyRelayed;
+@synthesize shouldPruneTurnPorts = _shouldPruneTurnPorts;
+@synthesize shouldPresumeWritableWhenFullyRelayed =
+ _shouldPresumeWritableWhenFullyRelayed;
- (instancetype)init {
if (self = [super init]) {
@@ -61,8 +62,8 @@
config.ice_backup_candidate_pair_ping_interval;
_keyType = RTCEncryptionKeyTypeECDSA;
_iceCandidatePoolSize = config.ice_candidate_pool_size;
- _pruneTurnPorts = config.prune_turn_ports;
- _presumeWritableWhenFullyRelayed =
+ _shouldPruneTurnPorts = config.prune_turn_ports;
+ _shouldPresumeWritableWhenFullyRelayed =
config.presume_writable_when_fully_relayed;
}
return self;
@@ -83,8 +84,8 @@
_iceConnectionReceivingTimeout,
_iceBackupCandidatePairPingInterval,
_iceCandidatePoolSize,
- _pruneTurnPorts,
- _presumeWritableWhenFullyRelayed];
+ _shouldPruneTurnPorts,
+ _shouldPresumeWritableWhenFullyRelayed];
}
#pragma mark - Private
@@ -128,9 +129,9 @@
nativeConfig->certificates.push_back(certificate);
}
nativeConfig->ice_candidate_pool_size = _iceCandidatePoolSize;
- nativeConfig->prune_turn_ports = _pruneTurnPorts;
+ nativeConfig->prune_turn_ports = _shouldPruneTurnPorts;
tkchin_webrtc 2016/07/11 19:52:21 _shouldPruneTurnPorts ? true : false;
honghaiz3 2016/07/11 20:00:00 Done. Thanks!
nativeConfig->presume_writable_when_fully_relayed =
- _presumeWritableWhenFullyRelayed;
+ _shouldPresumeWritableWhenFullyRelayed;
tkchin_webrtc 2016/07/11 19:52:21 _shouldPresumeWritableWhenFullyRelayed ? true : fa
honghaiz3 2016/07/11 20:00:00 Done.
return nativeConfig.release();
}

Powered by Google App Engine
This is Rietveld 408576698