Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: webrtc/video/video_loopback.cc

Issue 2136573002: Adding audio to video_quality_test. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: adding flags. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/video/video_quality_test.h » ('j') | webrtc/video/video_quality_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/video_loopback.cc
diff --git a/webrtc/video/video_loopback.cc b/webrtc/video/video_loopback.cc
index f3e13de34673466c475b16d51bad309390572d56..60c932ae62d7221ef8a98918550234a45f128659 100644
--- a/webrtc/video/video_loopback.cc
+++ b/webrtc/video/video_loopback.cc
@@ -191,6 +191,11 @@ DEFINE_bool(allow_reordering, false, "Allow packet reordering to occur");
DEFINE_bool(use_fec, false, "Use forward error correction.");
+DEFINE_bool(audio, false, "Add audio stream (no effect if duration defined)");
minyue-webrtc 2016/07/12 10:09:36 I do not know what is best to do with RunWithAnaly
stefan-webrtc 2016/08/08 14:11:18 I think we should make sure it fails if run with a
minyue-webrtc 2016/08/15 15:34:31 You are right. Done.
+
+DEFINE_bool(audio_video_sync, false, "Sync audio and video stream (no effect if"
+ " audio is false)");
+
DEFINE_string(
force_fieldtrials,
"",
@@ -240,7 +245,10 @@ void Loopback() {
{"video", 0.0, 0.0, flags::DurationSecs(), flags::OutputFilename(),
flags::GraphTitle()},
pipe_config,
- flags::FLAGS_logs};
+ flags::FLAGS_logs,
+ {},
+ flags::FLAGS_audio,
+ flags::FLAGS_audio_video_sync};
std::vector<std::string> stream_descriptors;
stream_descriptors.push_back(flags::Stream0());
« no previous file with comments | « no previous file | webrtc/video/video_quality_test.h » ('j') | webrtc/video/video_quality_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698