Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: webrtc/call/call.cc

Issue 2136533002: Only update codec type histogram if lifetime is long enough (10 sec). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: updated test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/call/call.cc
diff --git a/webrtc/call/call.cc b/webrtc/call/call.cc
index c85eaf6990b8ceb1a8a9a0f17fe6ca8b19064c68..76a1543460ea11ea21c4cb53c99ceb1015dea20d 100644
--- a/webrtc/call/call.cc
+++ b/webrtc/call/call.cc
@@ -136,6 +136,7 @@ class Call : public webrtc::Call,
void UpdateSendHistograms() EXCLUSIVE_LOCKS_REQUIRED(&bitrate_crit_);
void UpdateReceiveHistograms();
+ void UpdateHistograms();
void UpdateAggregateNetworkState();
Clock* const clock_;
@@ -196,6 +197,7 @@ class Call : public webrtc::Call,
VieRemb remb_;
const std::unique_ptr<CongestionController> congestion_controller_;
const std::unique_ptr<SendDelayStats> video_send_delay_stats_;
+ const int64_t start_ms_;
RTC_DISALLOW_COPY_AND_ASSIGN(Call);
};
@@ -231,11 +233,11 @@ Call::Call(const Call::Config& config)
min_allocated_send_bitrate_bps_(0),
num_bitrate_updates_(0),
configured_max_padding_bitrate_bps_(0),
-
remb_(clock_),
congestion_controller_(
new CongestionController(clock_, this, &remb_, event_log_.get())),
- video_send_delay_stats_(new SendDelayStats(clock_)) {
+ video_send_delay_stats_(new SendDelayStats(clock_)),
+ start_ms_(clock_->TimeInMilliseconds()) {
RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread());
RTC_DCHECK_GE(config.bitrate_config.min_bitrate_bps, 0);
RTC_DCHECK_GE(config.bitrate_config.start_bitrate_bps,
@@ -267,6 +269,7 @@ Call::~Call() {
RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread());
UpdateSendHistograms();
UpdateReceiveHistograms();
+ UpdateHistograms();
RTC_CHECK(audio_send_ssrcs_.empty());
RTC_CHECK(video_send_ssrcs_.empty());
RTC_CHECK(video_send_streams_.empty());
@@ -285,6 +288,12 @@ Call::~Call() {
Trace::ReturnTrace();
}
+void Call::UpdateHistograms() {
+ RTC_LOGGED_HISTOGRAM_COUNTS_100000(
+ "WebRTC.Call.LifetimeInSeconds",
+ (clock_->TimeInMilliseconds() - start_ms_) / 1000);
+}
+
void Call::UpdateSendHistograms() {
if (num_bitrate_updates_ == 0 || first_packet_sent_ms_ == -1)
return;

Powered by Google App Engine
This is Rietveld 408576698