Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2136533002: Only update codec type histogram if lifetime is long enough (10 sec). (Closed)

Created:
4 years, 5 months ago by åsapersson
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Only update codec type histogram if lifetime is long enough (10 sec). Add metrics for Call/VideoSendStream/VideoReceiveStream lifetime. BUG= Committed: https://crrev.com/4374a09f9bfb24e21ba1510fd6dbe40defada6c3 Cr-Commit-Position: refs/heads/master@{#13537}

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : updated test #

Total comments: 4

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -9 lines) Patch
M webrtc/api/androidtests/src/org/webrtc/PeerConnectionTest.java View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M webrtc/call/call.cc View 1 2 3 4 chunks +11 lines, -2 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/video/send_statistics_proxy.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 1 2 3 1 chunk +8 lines, -1 line 0 comments Download
M webrtc/video/send_statistics_proxy_unittest.cc View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
åsapersson
4 years, 5 months ago (2016-07-08 16:14:08 UTC) #3
pbos-webrtc
https://codereview.webrtc.org/2136533002/diff/40001/webrtc/video/end_to_end_tests.cc File webrtc/video/end_to_end_tests.cc (right): https://codereview.webrtc.org/2136533002/diff/40001/webrtc/video/end_to_end_tests.cc#newcode2133 webrtc/video/end_to_end_tests.cc:2133: EXPECT_EQ(2, metrics::NumSamples("WebRTC.Call.LifetimeInSeconds")); This sounds very flaky to me, deleting ...
4 years, 5 months ago (2016-07-10 17:43:03 UTC) #4
åsapersson
https://codereview.webrtc.org/2136533002/diff/40001/webrtc/video/end_to_end_tests.cc File webrtc/video/end_to_end_tests.cc (right): https://codereview.webrtc.org/2136533002/diff/40001/webrtc/video/end_to_end_tests.cc#newcode2133 webrtc/video/end_to_end_tests.cc:2133: EXPECT_EQ(2, metrics::NumSamples("WebRTC.Call.LifetimeInSeconds")); On 2016/07/10 17:43:03, pbos-webrtc wrote: > This ...
4 years, 5 months ago (2016-07-25 07:54:04 UTC) #5
pbos-webrtc
lgtm, thanks
4 years, 5 months ago (2016-07-25 09:26:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2136533002/60001
4 years, 5 months ago (2016-07-25 11:35:57 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6954)
4 years, 5 months ago (2016-07-25 11:40:27 UTC) #10
åsapersson
Magnus, can you have a look at webrtc/api/androidtests/src/org/webrtc/PeerConnectionTest.java
4 years, 5 months ago (2016-07-25 11:46:16 UTC) #12
magjed_webrtc
webrtc/api/androidtests/src/org/webrtc/PeerConnectionTest.java lgtm
4 years, 4 months ago (2016-07-26 13:14:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2136533002/60001
4 years, 4 months ago (2016-07-27 05:55:34 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-07-27 07:39:13 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 07:39:23 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4374a09f9bfb24e21ba1510fd6dbe40defada6c3
Cr-Commit-Position: refs/heads/master@{#13537}

Powered by Google App Engine
This is Rietveld 408576698