Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2135173002: Revert of Protect MessageQueue stop field with a critical section to avoid data races. (Closed)

Created:
4 years, 5 months ago by henrika_webrtc
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Protect MessageQueue stop field with a critical section to avoid data races. (patchset #5 id:80001 of https://codereview.webrtc.org/2023193002/ ) Reason for revert: Only reasonable CL in blameslist for broken Chrome FYI bots on all platforms. See https://build.chromium.org/p/chromium.webrtc.fyi/waterfall?builder=Mac%20Builder Original issue's description: > Protect MessageQueue stop field with a critical section to avoid data races. > > Committed: https://crrev.com/1d35d2971b1e89b3ecadb7fb1ff064f9af850ad4 > Cr-Commit-Position: refs/heads/master@{#13430} TBR=pthatcher@webrtc.org,tommi@webrtc.org,deadbeef@webrtc.org,tommi@chromium.org,pbos@webrtc.org,andresp@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a2c900877d8338130210c99fec1c8e8e59defea4 Cr-Commit-Position: refs/heads/master@{#13431}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M webrtc/base/messagequeue.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/base/messagequeue.cc View 5 chunks +8 lines, -12 lines 0 comments Download
M webrtc/base/thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/build/sanitizers/tsan_suppressions_webrtc.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
henrika_webrtc
Created Revert of Protect MessageQueue stop field with a critical section to avoid data races.
4 years, 5 months ago (2016-07-11 09:48:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2135173002/1
4 years, 5 months ago (2016-07-11 09:48:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 09:48:46 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a2c900877d8338130210c99fec1c8e8e59defea4 Cr-Commit-Position: refs/heads/master@{#13431}
4 years, 5 months ago (2016-07-11 09:48:56 UTC) #7
andresp
4 years, 5 months ago (2016-07-11 09:49:04 UTC) #8
Message was sent while issue was closed.
On 2016/07/11 09:48:46, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1)

lgtm

Powered by Google App Engine
This is Rietveld 408576698