Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Unified Diff: webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h

Issue 2132563002: Rewrote UpdateToMix in the audio mixer. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@remove_memory_pool
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h
diff --git a/webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h b/webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h
index 8491ce6d0c3bdfbb3da64c80aa2f900f807c422e..d5f037b0a7c09441109cade5364c50e828d8b616 100644
--- a/webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h
+++ b/webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h
@@ -84,17 +84,10 @@ class NewAudioConferenceMixerImpl : public NewAudioConferenceMixer {
int32_t SetOutputFrequency(const Frequency& frequency);
Frequency OutputFrequency() const;
- // Fills mixList with the AudioFrames pointers that should be used when
- // mixing.
- // maxAudioFrameCounter both input and output specifies how many more
- // AudioFrames that are allowed to be mixed.
- // rampOutList contain AudioFrames corresponding to an audio stream that
- // used to be mixed but shouldn't be mixed any longer. These AudioFrames
- // should be ramped out over this AudioFrame to avoid audio discontinuities.
- void UpdateToMix(AudioFrameList* mixList,
- AudioFrameList* rampOutList,
- std::map<int, MixerAudioSource*>* mixParticipantList,
- size_t* maxAudioFrameCounter) const;
+ // Compute what participants to mix from _participantList. Ramp in
+ // and out. Update mixed status. maxAudioFrameCounter specifies how
+ // many participants are allowed to be mixed.
+ AudioFrameList UpdateToMix(size_t maxAudioFrameCounter) const;
// Return the lowest mixing frequency that can be used without having to
// downsample any audio.
@@ -105,11 +98,6 @@ class NewAudioConferenceMixerImpl : public NewAudioConferenceMixer {
// Return the AudioFrames that should be mixed anonymously.
void GetAdditionalAudio(AudioFrameList* additionalFramesList) const;
- // Update the NewMixHistory of all MixerAudioSources. mixedParticipantsList
- // should contain a map of MixerAudioSources that have been mixed.
- void UpdateMixedStatus(
- const std::map<int, MixerAudioSource*>& mixedParticipantsList) const;
-
// Clears audioFrameList and reclaims all memory associated with it.
void ClearAudioFrameList(AudioFrameList* audioFrameList) const;

Powered by Google App Engine
This is Rietveld 408576698